Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update WW3 with 20240116 commit #2550

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

JessicaMeixner-NOAA
Copy link
Collaborator

@JessicaMeixner-NOAA JessicaMeixner-NOAA commented Jan 6, 2025

Commit Queue Requirements:

  • Fill out all sections of this template.
  • All sub component pull requests have been reviewed by their code managers.
  • Run the full Intel+GNU RT suite (compared to current baselines) on either Hera/Derecho/Hercules
  • Commit 'test_changes.list' from previous step

Description:

This PR updates WW3 (after PR #2549) and isolates the commit that changes answers. This WW3 commit can be seen here: NOAA-EMC/WW3@3952826
Many efforts were made to understand why this PR is changing answers. Different parts of the PR changes were isolated, print statements, etc, were made however so far we have not been able to identify why/what changed. The resulting changes are small. This chnages answers to anything using WW3.

Commit Message:

Update WW3 with 2024-1-16 commit

* UFSWM - 
  * WW3 - Update one commit hash

Priority:

  • Normal: Part of a series of PR that has updates needed for GFSv17.

Git Tracking

UFSWM:

  • None

Sub component Pull Requests:

UFSWM Blocking Dependencies:


Changes

Regression Test Changes (Please commit test_changes.list):

  • PR Updates/Changes Baselines.

Input data Changes:

  • None.

Library Changes/Upgrades:

  • No Updates

Testing Log:

  • RDHPCS
    • Hera
    • Orion
    • Hercules
    • Jet
    • GaeaC5
    • GaeaC6
    • Derecho
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
  • opnReqTest (complete task if unnecessary)

@JessicaMeixner-NOAA
Copy link
Collaborator Author

I know that this unexpectedly changes baselines. If there are any additional tests anyone wants to see, please let me know so I can get those started.

@DeniseWorthen
Copy link
Collaborator

I looked at this commit (for my own curiosity) over the past year. Using mediator history files I found that the first difference arises w/ very very small b4b differences (~10-30) at a single point location for the exported stokes drift components. I think we need to just accept it and move on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants