Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

actions-ci-updates #398

Closed
wants to merge 10 commits into from
Closed

actions-ci-updates #398

wants to merge 10 commits into from

Conversation

maddenp-noaa
Copy link
Collaborator

Synopsis

Fix (hopefully) Actions CI settings.

Type

  • Tooling (CI, code-quality, packaging, revision-control, etc.)

Impact

  • This is a non-breaking change (existing functionality continues to work as expected)

Checklist

  • I have added myself and any co-authors to the PR's Assignees list.

maddenp-noaa and others added 10 commits October 5, 2023 12:20
@maddenp-noaa
Release Test (#309)
beb0bf4
@maddenp-noaa
Install anaconda-client for CI jobs
6f1c5fe
@maddenp-noaa
Hotfix: Try to locate ALL packages built by CI
279e681
@maddenp-noaa
Squashed commit of the following:
1b3ddf2 
commit 142fdf8
Author: Paul Madden <[email protected]>
Date:   Wed Jan 24 23:57:25 2024 +0000

    Remove unneeded Actions scripts, fix whitespace

commit 4eb63b8
Author: Paul Madden <[email protected]>
Date:   Wed Jan 24 23:55:59 2024 +0000

    Squashed commit of the following:

    commit 279e681
    Author: Paul Madden <[email protected]>
    Date:   Thu Oct 5 20:44:02 2023 +0000

        Hotfix: Try to locate ALL packages built by CI

    commit 6f1c5fe
    Author: Paul Madden <[email protected]>
    Date:   Thu Oct 5 18:43:58 2023 +0000

        Install anaconda-client for CI jobs

    commit beb0bf4
    Author: Paul Madden <[email protected]>
    Date:   Thu Oct 5 12:20:28 2023 -0600

        Release Test (#309)

commit 58e4090
Author: Paul Madden <[email protected]>
Date:   Wed Jan 24 23:44:39 2024 +0000

    main-updates (#396)

commit 0a2e998
Author: Paul Madden <[email protected]>
Date:   Wed Jan 24 23:03:49 2024 +0000

    typechecking-updates (#394)

commit e5d2462
Author: Brian Weir <[email protected]>
Date:   Wed Jan 24 16:45:33 2024 -0600

    UW-479: add uw --debug CLI option (#391)

    * updated testing coverage and errors

    * update check naming to verbosity

    * Fix merge errors and suggestions
    stacktrace test currently fails

    * moved catch to try block, updated test
    test still failing

    * updating fixed test and docs

    * updated feedback and improved tests

    * Update docs/sections/user_guide/cli/mode_config.rst

    the the is unnecessary

    Co-authored-by: Paul Madden <[email protected]>

    * too many 'the'

    * Fixed extra line, updated logging error message

    ---------

    Co-authored-by: Paul Madden <[email protected]>

commit 24fb5c9
Author: Paul Madden <[email protected]>
Date:   Wed Jan 24 20:23:41 2024 +0000

    UW-419 (#393)

commit 713d19c
Author: Christina Holt <[email protected]>
Date:   Wed Jan 24 13:02:20 2024 -0700

    UW433: Forecast docs (#389)

    Documentation for the forecast driver. Also includes a couple of changes to code to be consistent with docs.

commit ad08cc1
Author: Christina Holt <[email protected]>
Date:   Wed Jan 24 12:39:45 2024 -0700

    Fixes to forecast driver found while testing. (#378)

    Fixing a couple of issues when testing the forecast driver that needed to be addressed.

commit e578ffd
Author: Paul Madden <[email protected]>
Date:   Tue Jan 23 15:23:58 2024 +0000

    nml-updates (#392)

commit 965d8dd
Author: Paul Madden <[email protected]>
Date:   Fri Jan 19 21:54:23 2024 +0000

    tagged-scalars (#388)

commit 5189cf7
Author: Paul Madden <[email protected]>
Date:   Wed Jan 17 11:55:50 2024 -0700

    UW-476 (#387)

commit 43e2be1
Author: Paul Madden <[email protected]>
Date:   Wed Jan 17 11:43:11 2024 -0700

    UW-477 (#386)

commit 97f7474
Author: Paul Madden <[email protected]>
Date:   Wed Jan 17 09:04:41 2024 -0700

    UW-474 (#385)

commit 725ed3e
Author: Paul Madden <[email protected]>
Date:   Tue Jan 16 15:19:28 2024 -0700

    UW-472 (#384)

commit b22cf75
Author: Paul Madden <[email protected]>
Date:   Tue Jan 16 13:26:34 2024 -0700

    typo-and-whitespace-fixes (#383)

commit 884f6d9
Author: Paul Madden <[email protected]>
Date:   Fri Jan 12 13:14:22 2024 -0700

    conda-pkg-install-docs (#382)

commit e35411c
Author: Paul Madden <[email protected]>
Date:   Fri Jan 12 16:09:11 2024 +0000

    Fix doc links in README.md

commit bfe4bd4
Author: Paul Madden <[email protected]>
Date:   Thu Jan 11 03:17:39 2024 +0000

    Update RTD badge

commit 7bf7984
Author: Paul Madden <[email protected]>
Date:   Wed Jan 10 19:59:12 2024 -0700

    doc-update (#381)

commit 9f872da
Author: Brian Weir <[email protected]>
Date:   Thu Jan 4 17:23:21 2024 -0600

    Fixing CLI config validate (#375)

    * fixing cli config validate

    * change to input_file

    * fix names in patching

commit 0ab2888
Author: Paul Madden <[email protected]>
Date:   Wed Dec 20 10:17:28 2023 -0700

    Add make target to remove development environment (#368)

commit 9f9d13f
Author: Paul Madden <[email protected]>
Date:   Wed Dec 20 10:06:07 2023 -0700

    UW-454 (#367)

commit 6fa5c9c
Author: Emily Carpenter <[email protected]>
Date:   Wed Dec 20 10:16:28 2023 -0500

    UW-421: Replace uw config realize --values-file with --supplemental-configs/files, allowing for positional arguments (#365)

    * move dereference

    * WIP

    * tests passing

    * positional arguments

    * tests and typos

    * update doc strings

    * pluralize

    * comment for HelpFormatter

    * cornucopia of change

    * remove '=None'

    * remove '=None'

    * revert

commit 74e9197
Author: Paul Madden <[email protected]>
Date:   Tue Dec 12 09:28:40 2023 -0700

    Misc updates 2023-12-06 (#359)

commit ee5e381
Author: Paul Madden <[email protected]>
Date:   Fri Dec 8 10:51:15 2023 -0700

    UW-440 & UW-442 (#358)

commit 2c41888
Author: Paul Madden <[email protected]>
Date:   Wed Dec 6 10:52:08 2023 -0700

    UW-439 (#357)

commit 05923a6
Author: Brian Weir <[email protected]>
Date:   Wed Dec 6 10:51:23 2023 -0600

    UW-420: Forbid level-incompatible config transformations (#353)

    * Update _config_check_depths() to universal
    Added depth check to _realize_config_update()

    * expanded to check dump_dict() instances

    * updated depth check to be universal
    tests expanded as necessary
    eror messages now appropriate for each mode

    * added feedback, expanded tests, fixed formats

    * reworked depth check to 3 mode versions

    * Fixing doc and log messages

    * returned Union functionality, now checking dump()

    * refactored to pass lambda

    * Fix comment strings

    * replace hard coded depth message with depth()

commit f9d3147
Author: Paul Madden <[email protected]>
Date:   Fri Dec 1 08:29:03 2023 -0700

    UW-386 (#354)

commit 66aeb5f
Author: Paul Madden <[email protected]>
Date:   Thu Nov 30 14:07:43 2023 -0700

    Dependency Package Update 2023-11-30 (#356)

    Update dependency packages

commit 6af0c64
Author: Paul Madden <[email protected]>
Date:   Thu Nov 30 08:41:39 2023 -0700

    cycledef-fixup (#351)

commit d6319db
Author: Paul Madden <[email protected]>
Date:   Mon Nov 27 10:58:46 2023 -0700

    UW-438 (#349)

commit 3c93dfa
Author: Brian Weir <[email protected]>
Date:   Tue Nov 21 12:36:13 2023 -0600

    UW-418: Split .ini & .sh handling (#348)

    * Split bash handling to sh.py
    Updated affected tests and config references
    One fix in sh._load() remaining

    * Updating test_base, currently failing

    * Included several recommended changes, see notes
    Formats now have _MAXDEPTH
    split off two methods for ConfigParser dicts
    updated test files
    updated ini and sh logic
    still solving failing tests

    * tests fixed; does not convert to/from sh

    * Feedback in consistency and thoroughness added
    Need to resolve depths and types still

    * Removed dump depth check, fixed DEPTH in formats

    * removed unnecessary imports

    * Refactored Config section handling
    Removed additional uses of 'bash' where appropriate

    * removed comprehensions

    * fixed test_ini description error

commit 051b6d3
Author: NaureenBharwaniNOAA <[email protected]>
Date:   Tue Nov 21 09:56:34 2023 -0600

    UW-415 (#341)

    * WIP

    * Factoring out taskdep [skip ci]

    * taskdep working properly [skip ci]

    * Added datadep tag

    * Added timedep

    * Added some operator str literals

    * WIP on parametrization

    * Updated test case for datadep and timedep

    * Added reserved words to str literals

    * Added strequality tags

    * Added Boolean operators

    * WIP on operators

    * Updating true/false tags [skip ci]

    * Removed true/false tags, updated schema [ci skip]

    * Remove true/false tags from the schema [ci skip]

    * Added offset tag in schema to timedep [ci skip]

    * Undo changes to the Relax NG schema [ci skip]

    * Removed offset attr from timedep in schema [ci skip]

    * Fixed datadep and timedep tests

    * Modified operator test case [ci skip]

    * Removed TimePattern from schema

    * Working on operators nested dict test [ci skip]

    * Modified test case

    * Modified task dependency method [ci skip]

    * Modified methods/tests to look cleaner

    * Added check for tag name

    * Added docstrings to methods

    * DRY out reusable variables

    * Final cleanup

    * Fixing formatting/linter issues

    * Minor removals

    * Reordering of methods/tests lexicographically

    * Reordered methods/tests lexicographically

    * Added return type annotation

    * Reorder arguments

    * Reordered docstr for block/tag

    * Combined oeprator/operands

    * Updated docstr

commit c2681e7
Author: Emily Carpenter <[email protected]>
Date:   Fri Nov 17 11:59:05 2023 -0500

    UW-371: refactor of render()  (#346)

    * WIP

    * rearranging functions

    * typos and name changes

    * simplify test

    * adding definite articles

    * found spelling mistakes

commit dccc67e
Author: Paul Madden <[email protected]>
Date:   Wed Nov 15 18:09:59 2023 -0700

    Update PR template (#343)

commit 7f77a80
Author: Paul Madden <[email protected]>
Date:   Wed Nov 15 07:38:40 2023 -0700

    UW-370 (#340)

commit 93ed4d1
Author: Paul Madden <[email protected]>
Date:   Thu Nov 9 12:52:59 2023 -0700

    ci-improvements (#342)

commit 953e9a7
Author: Paul Madden <[email protected]>
Date:   Mon Nov 6 09:04:47 2023 -0700

    UW-364 (#338)

    Co-authored-by: Naureen Bharwani <[email protected]>

commit 5de7088
Author: Paul Madden <[email protected]>
Date:   Fri Nov 3 08:18:23 2023 -0600

    UW-407 (#335)

commit 2e4cff3
Author: Paul Madden <[email protected]>
Date:   Thu Nov 2 14:01:15 2023 -0600

    UW-363 (#334)

commit 6a99d9e
Author: Emily Carpenter <[email protected]>
Date:   Thu Nov 2 15:46:34 2023 -0400

    UW-408: Refactor of forecast's run method (#327)

    * added dry run to prepare directories

    * added logging to prepare config files

    * added prepare batch script method

    * full command -> prepare & execute

    * WIP, dry test failing

    * from UW Group

    * failing local execution test

    * before-the-fact log messages

    * updated tests

    * updated run_cmd doc string

    * updated var name

    * fixed spelling

    * doc string updates

    * doc string changes

commit 5c14776
Author: Paul Madden <[email protected]>
Date:   Wed Nov 1 11:54:24 2023 -0600

    UW-365 (#332)

commit 8957f80
Author: Brian Weir <[email protected]>
Date:   Wed Nov 1 10:14:15 2023 -0500

    UW-412: expand tests to also not provide optional args (#330)

    * added cli tests without optional args
    _dict_from_key_eq_val_strings now can be optional

    * tests now use parse_args, reverting None option

    * removed test_cli use of STR.render for "render"

    * merging fixed; translate/validate tests still fail

    * tests fixed with hardcoded formats

    * Removed use of _parse_args() from all cli tests

    * fixed test typing

commit ac5879a
Author: Paul Madden <[email protected]>
Date:   Tue Oct 31 14:42:35 2023 -0600

    cli-test-fixup (#331)

commit a6335ce
Author: Paul Madden <[email protected]>
Date:   Tue Oct 31 10:09:40 2023 -0600

    post-uw-376-items (#328)

commit e90fac4
Author: Paul Madden <[email protected]>
Date:   Tue Oct 31 07:13:59 2023 -0600

    UW-376 (#326)

commit 1cf4220
Author: Brian Weir <[email protected]>
Date:   Thu Oct 26 13:56:05 2023 -0500

    UW-413: Ensure CLI functions accept file and stdin streams for both input and output (#324)

    * Fix rocoto and jinja output calls to handle stream

    * Fix required output; revert jinja to limit scope

    * Restored changes to j2template

    * missed save on import declaration

    * Added recommended refactor of realize_rocoto_xml

    * Adding additional feedback to fix validate
    also, no longer have to __enter__ on mock

    * Fix tests after merging; piping and redirect works

    * Fixed test mock, added feedback of renaming

    * reverting to etree.fromstring()

    * Further simplified realize()

commit 22503a3
Author: Paul Madden <[email protected]>
Date:   Thu Oct 26 09:58:52 2023 -0600

    rereadable-stdin (#325)

commit ae4ef70
Author: Paul Madden <[email protected]>
Date:   Tue Oct 24 09:36:37 2023 -0600

    switchable-logging (#320)

commit 4291155
Author: Brian Weir <[email protected]>
Date:   Fri Oct 20 11:41:23 2023 -0500

    Fix command-line use of uw rocoto (#321)

    * fixed import

commit ac31f4e
Author: Brian Weir <[email protected]>
Date:   Thu Oct 19 09:44:18 2023 -0500

    UW 322 as a user, I would like to validate my rocoto xml workflow, given the rocoto native schema (#317)

    * Start of CLI, need inline validation and tests

    * updates to fix issues
    Tests in progress
    Will recheck file.py edits

    * updates to testing

    * add inline validation of input and output

    * fixed tests and logic
    reverted file.py changes

    * Incorporating multiple suggestions
    Pending rocoto.py edits and log handling

    * added realize_rocoto_xml(), tests in progress

    * Added verbose logging, tests in progress

    * fixes done, need rocoto tests and paths

    * Major suggestions added, fixing minor issues

    * all 'as m' clarified to 'as module'

    * fixed path handling

    * Incorporating feedback and correcting validation
    still need to fix coverage of invalid XML

    * removed pragma, added temp output handling
    note: coverage still an issue

    * change naming from input_yaml to config_file

    * Resolving feedback, still fixing coverage

    * Fixing residual naming issues

    * invalid_xml test coverage fixed

    * fixed  importers to handle OptionalPath

    * Docstrings fixed, investigating rocoto.jinja2

    * Clarified schema vs template; current write error

    * Fixed template and task handling return
    Current test issue with passing over temp xml

    * fixed tests

    * Removed unnecessary declarations

    * Several fixes; still an issue in rocoto.jinja2

    * unpatched write

commit 2033263
Author: Paul Madden <[email protected]>
Date:   Thu Oct 19 16:26:46 2023 +0200

    release-workflow-case-fix (#319)

commit 601ff4e
Author: Paul Madden <[email protected]>
Date:   Fri Oct 6 08:29:00 2023 -0600

    jq-formatting (#312)

commit 8cf2231
Author: Christina Holt <[email protected]>
Date:   Thu Oct 5 16:49:34 2023 -0600

    UW-312 Congealing the FV3Forecast Driver (#291)

    Refactored FV3Forecast methods that create model_configure, namelist, and field table to make calls to the same private base function.
    Updated doc strings in forecast driver to follow newer format.
    Added cycle and date to input arguments for uw forecast run
    Attempted to Clean the run() method.
    Added a method that will set mpi variables before running the mpi command.
    Add run job method to scheduler class.
    Add dump method to BatchScript class
    Updated the forecast schema to reflect the sections needed to "fully" configure a forecast. Caveat -- fully configure it for standalone regional use case.

commit cbf3ef3
Author: Paul Madden <[email protected]>
Date:   Thu Oct 5 15:15:55 2023 -0600

    ci-publish-fixes (#311)

    CI publish fixes from main branch

commit 2bcee70
Author: Paul Madden <[email protected]>
Date:   Thu Oct 5 12:05:22 2023 -0600

    disconnect-jenkins (#308)

    Remove Jenkins CI config

commit 4868c49
Author: Paul Madden <[email protected]>
Date:   Thu Oct 5 10:24:21 2023 -0600

    uw-317 (#305)

commit 4ddf53c
Author: Brian Weir <[email protected]>
Date:   Thu Oct 5 10:41:11 2023 -0500

    UW-382 Create JSONSchema section for dependency section tags (#292)

    * First schema draft with one level, untested

    * draft 1 to try recursion

    * Combined multiple solutions

    * preliminary test version

    * ChatGPT corrections applied, still test error

    * Comment added to test git actions

    * Validator update from PR #291

    * Updating to test invalid entry
    Additional validator changes added

    * Fixed time regex, looping, some errors
    anyOf still overmatching

    * Removed anyOf list and added datadep comprehension

    * cleaned up rocoto.jsonschema merge

    * Added missing requirements and patterns

    * quick redundant requirement edit

    * fixed 'some' tag

    * Updated to match loop pattern of UW-381

    * corrected placement of dependency to under task

    * Updated to bring in like with UW-381
    Still requires fail condition tests for dependency

    * fix conflict resolution error

    * Validation failure tests added

    * added regex_logged()

    * Update docs from #302 to fix ReadTheDocs

    * Overriding jq -r to restore jsonschema

    * Update to dependentSchemas and 2020 draft

    * Fixed order standards in test_validator

commit 7638236
Author: Paul Madden <[email protected]>
Date:   Wed Oct 4 16:57:59 2023 -0600

    uw-246 (#303)
@maddenp-noaa
Post-merge fixup
5cb9bf6
@maddenp-noaa
Test commit
8b39e1f
@maddenp-noaa
Undo test commit
5a97a75
@maddenp-noaa
Merge branch 'develop' into release-v1.1.0
6647d3b
@maddenp-noaa
Trigger release workflow only on push to main
c9e3d49
@maddenp-noaa
Trigger test workflow for main branch
369ba88
@maddenp-noaa maddenp-noaa self-assigned this Jan 25, 2024
@maddenp-noaa maddenp-noaa marked this pull request as ready for review January 25, 2024 02:55
@maddenp-noaa maddenp-noaa deleted the release-v1.1.0 branch January 25, 2024 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NaureenBharwaniNOAA NaureenBharwaniNOAA Awaiting requested review from NaureenBharwaniNOAA

@christinaholtNOAA christinaholtNOAA Awaiting requested review from christinaholtNOAA

@elcarpenterNOAA elcarpenterNOAA Awaiting requested review from elcarpenterNOAA

@fgabelmannjr fgabelmannjr Awaiting requested review from fgabelmannjr

@WeirAE WeirAE Awaiting requested review from WeirAE

Assignees

@maddenp-noaa maddenp-noaa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@maddenp-noaa