Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass custom logger to iotaa #411

Merged
merged 2 commits into from
Feb 22, 2024
Merged

Pass custom logger to iotaa #411

merged 2 commits into from
Feb 22, 2024

Conversation

maddenp-noaa
Copy link
Collaborator

Synopsis

If an API user configures use of a custom logger, have iotaa use that custom logger, too.

Type

  • Bug fix (corrects a known issue)

Impact

  • This is a non-breaking change (existing functionality continues to work as expected)

Checklist

  • I have added myself and any co-authors to the PR's Assignees list.
  • I have reviewed the documentation and have made any updates necessitated by this change.

@maddenp-noaa maddenp-noaa self-assigned this Feb 20, 2024
christinaholtNOAA
christinaholtNOAA approved these changes Feb 21, 2024
View reviewed changes
Copy link
Collaborator

@christinaholtNOAA christinaholtNOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maddenp-noaa maddenp-noaa added the bug Something isn't working label Feb 21, 2024
WeirAE
WeirAE approved these changes Feb 22, 2024
View reviewed changes
Copy link
Contributor

@WeirAE WeirAE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maddenp-noaa maddenp-noaa marked this pull request as ready for review February 22, 2024 23:47
@maddenp-noaa maddenp-noaa merged commit 4fa8106 into ufs-community:main Feb 22, 2024
2 checks passed
@maddenp-noaa maddenp-noaa deleted the logging-fix branch February 22, 2024 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NaureenBharwaniNOAA NaureenBharwaniNOAA NaureenBharwaniNOAA approved these changes

@WeirAE WeirAE WeirAE approved these changes

@christinaholtNOAA christinaholtNOAA christinaholtNOAA approved these changes

@elcarpenterNOAA elcarpenterNOAA Awaiting requested review from elcarpenterNOAA elcarpenterNOAA is a code owner

@fgabelmannjr fgabelmannjr Awaiting requested review from fgabelmannjr

Assignees

@maddenp-noaa maddenp-noaa

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@maddenp-noaa @christinaholtNOAA @WeirAE @NaureenBharwaniNOAA @maddenp