Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UW-504: Allow YAML as supplemental config always #421

Merged
merged 13 commits into from
Feb 29, 2024
Merged

UW-504: Allow YAML as supplemental config always #421

merged 13 commits into from
Feb 29, 2024

Conversation

WeirAE
Copy link
Contributor

@WeirAE WeirAE commented Feb 29, 2024 •
edited
Loading

Synopsis

config.update() must allow YAML regardless of input/output files
Continuation of #413 ; completes #419

Type

  • Bug fix (corrects a known issue)
  • Code maintenance (refactoring, etc. without behavior change)
  • Documentation
  • Enhancement (adds a new functionality)
  • Tooling (CI, code-quality, packaging, revision-control, etc.)

Impact

  • This is a non-breaking change (existing functionality continues to work as expected)
  • This is a breaking change (changes existing functionality)

Checklist

  • I have added myself and any co-authors to the PR's Assignees list.
  • I have reviewed the documentation and have made any updates necessitated by this change.

@WeirAE WeirAE added the feature Added functionality label Feb 29, 2024
@WeirAE WeirAE self-assigned this Feb 29, 2024
@WeirAE WeirAE changed the title Uw 504 UW-504: Allow YAML as supplemental config always Feb 29, 2024
christinaholtNOAA
christinaholtNOAA approved these changes Feb 29, 2024
View reviewed changes
Copy link
Collaborator

@christinaholtNOAA christinaholtNOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WeirAE WeirAE merged commit 32c327e into ufs-community:main Feb 29, 2024
2 checks passed
@WeirAE WeirAE deleted the UW-504 branch March 14, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maddenp-noaa maddenp-noaa maddenp-noaa approved these changes

@christinaholtNOAA christinaholtNOAA christinaholtNOAA approved these changes

@NaureenBharwaniNOAA NaureenBharwaniNOAA Awaiting requested review from NaureenBharwaniNOAA NaureenBharwaniNOAA is a code owner

@elcarpenterNOAA elcarpenterNOAA Awaiting requested review from elcarpenterNOAA elcarpenterNOAA is a code owner

@fgabelmannjr fgabelmannjr Awaiting requested review from fgabelmannjr

Assignees

@WeirAE WeirAE

Labels
feature Added functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@WeirAE @christinaholtNOAA @maddenp-noaa