-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Omnibus 2024-11-27 #663
Merged
Merged
Omnibus 2024-11-27 #663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maddenp-noaa
commented
Nov 27, 2024
maddenp-noaa
requested review from
NaureenBharwaniNOAA,
christinaholtNOAA,
elcarpenterNOAA,
fgabelmannjr,
WeirAE and
Byrnetp
as code owners
November 27, 2024 06:47
maddenp-noaa
commented
Nov 27, 2024
elcarpenterNOAA
approved these changes
Nov 27, 2024
Co-authored-by: Emily Carpenter <[email protected]>
NaureenBharwaniNOAA
approved these changes
Nov 27, 2024
christinaholtNOAA
approved these changes
Dec 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. This makes for a much cleaner user experience than my workaround.
Maybe a small docs change is needed?
Byrnetp
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Synopsis
.github
such that the Test workflow will be run for PRs or pushes to all branches. This means that tests will run for updates on release branches, which seems like it would have been a good idea to always be doing.setuptools
to conda build requirements, as it appears not to be automatically installed with Python 3.13 now in CI jobs, but is required for theuwtools
build.!include
tag.make docs
.int
,bool
, etc.). See below (and the new unit tests) for examples.Given
config.yaml
Old behavior:
New behavior:
Type
Impact
Checklist