-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add !dict and !list UW YAML tags #682
Add !dict and !list UW YAML tags #682
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Just one comment on ordering.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Just a handful of minor comments.
Co-authored-by: Paul Madden <[email protected]>
* WIP * ScalarNode -> Node * Simplify * Simplify * Simplify * Update docstring * WIP * WIP * Revert UWYAMLTag class hierarchy * Revert unnecessary class change * Rename function * WIP * convert() -> @Property convert * WIP * Tests pass * Improve test-function names * Improve test-function names * Unit tests @ 100% * Doc updates * Simplify * Update notebooks * Revert change to pyproject.toml * Remove commented-out breakpoint * Update * Improve non-str hint * Improve non-str hint * Doc update * Custom UWYAMLConvert __repr__()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few comments below. No changes necessary, just some curiosities.
Synopsis
Fixes #676.
!dict
and!list
UW YAML tags.!bool
tag to Python's truthiness standards.Type
Impact
Checklist