Merge pull request #1 from ultraleap/feature/git-missing-ref-lookup

Add missing ref lookup via libgit2sharp

Editor/DependencyBrowser.cs

@@ -5,7 +5,7 @@
 using UnityEditor.PackageManager;
 using UnityEngine;
 
-namespace Leap.Unity
+namespace Leap.Unity.Dependency
 {
     internal class DependencyBrowser : EditorWindow
     {
@@ -45,6 +45,11 @@ internal class DependencyBrowser : EditorWindow
         private bool filterToOnlyUnused;
         private bool filterToAssetsMissingRefs;
         private bool showExternalPackages;
+
+        private int repositoryLookupCommitLimit;
+        private string repositoryLookupCommitLimitKey = "UltraleapDependencyBrowserGitRepoLookupCommitLimit";
+        private string repositoryLookupRoot;
+        private readonly string repositoryLookupRootKey = "UltraleapDependencyBrowserGitRepoLookupRoot";
 
         private event Action resizeOccurred;
 
@@ -81,7 +86,8 @@ private void OnEnable()
             currentVerticalDistance = windowSize.y / 2f;
             horizontalResizeInteractionRect = new Rect(currentHorizontalDistance, 0f, 8f, windowSize.y);
             verticalResizeInteractionRect = new Rect(currentHorizontalDistance + resizerSpacing, currentVerticalDistance, windowSize.x - currentHorizontalDistance - resizerSpacing, 8f);
-
+            repositoryLookupRoot = EditorPrefs.GetString(repositoryLookupRootKey, Environment.CurrentDirectory);
+            repositoryLookupCommitLimit = EditorPrefs.GetInt(repositoryLookupCommitLimitKey, 500);
 
             void UpdateResizeInteractionRects()
             {
@@ -112,7 +118,15 @@ void DrawLeftColumn()
             filterToAssetsMissingRefs = GUILayout.Toggle(filterToAssetsMissingRefs, "Filter to assets with missing references");
             showExternalPackages = GUILayout.Toggle(showExternalPackages, "Show external packages");
             editor.DrawSortPopup();
-
+
+            repositoryLookupRoot = GUILayout.TextField(repositoryLookupRoot);
+            EditorPrefs.SetString(repositoryLookupRootKey, repositoryLookupRoot);
+            GUILayout.BeginHorizontal();
+            repositoryLookupCommitLimit = EditorGUILayout.IntField(repositoryLookupCommitLimit);
+            EditorPrefs.SetInt(repositoryLookupCommitLimitKey, repositoryLookupCommitLimit);
+            editor.DrawGitLookupMissingRefButton(repositoryLookupRoot, repositoryLookupCommitLimit);
+            GUILayout.EndHorizontal();
+
             GUILayout.Label($"Current selection: {editor.Selected}");
             GUILayout.Label("Select an asset or folder");
             _selectionTreeViewDrawer ??= editor.CreateNodeViewDrawer(

Editor/DependencyFolderNode.cs

@@ -1,7 +1,7 @@
 using System.Collections.Generic;
 using System.Linq;
 
-namespace Leap.Unity
+namespace Leap.Unity.Dependency
 {
     internal class DependencyFolderNode : DependencyNodeBase
     {

Editor/DependencyGuiUtilities.cs

@@ -1,8 +1,12 @@
 using System;
 using System.Collections.Generic;
+using System.IO;
+using System.Linq;
+using LibGit2Sharp;
 using UnityEngine;
+using Tree = LibGit2Sharp.Tree;
 
-namespace Leap.Unity
+namespace Leap.Unity.Dependency
 {
     internal static class DependencyGuiUtilities
     {
@@ -80,5 +84,52 @@ public static string BytesToString(long byteCount)
             double num = Math.Round(bytes / Math.Pow(1024, place), 1);
             return (Math.Sign(byteCount) * num) + suf[place];
         }
+
+        public static Dictionary<DependencyNode, List<string>> LookupMissingReferences(IReadOnlyList<DependencyNode> missingReferences, string repositoryDiscoverRootPath, int commitLimit)
+        {
+            if (!(Repository.Discover(repositoryDiscoverRootPath) is { } repoDirectory)) return null;
+            var repo = new Repository(repoDirectory);
+            var checkedBlobs = new HashSet<string>();
+            var possibleFiles = new Dictionary<DependencyNode, HashSet<string>>();
+
+            void RecurseTree(Tree commitTree)
+            {
+                foreach (var entry in commitTree)
+                {
+                    switch (entry.Target)
+                    {
+                        case Blob blob:
+                            if (!entry.Name.EndsWith(".meta")) continue; // Only care about meta files
+                            if (blob.IsBinary) continue; // Why is it not text? Log this?
+                            if (!checkedBlobs.Add(blob.Sha)) continue; // Already checked this blob
+                            var filepath = $"{repo.Info.WorkingDirectory}{entry.Path}";
+
+                            var content = blob.GetContentText();
+                            foreach (var missingRef in missingReferences)
+                            {
+                                if (!content.Contains(missingRef.Guid)) continue;
+                                if (!possibleFiles.TryGetValue(missingRef, out var missingRefPossibleFiles))
+                                {
+                                    missingRefPossibleFiles = possibleFiles[missingRef] = new HashSet<string>();
+                                }
+
+                                missingRefPossibleFiles.Add(filepath);
+                            }
+
+                            break;
+                        case Tree t:
+                            RecurseTree(t);
+                            break;
+                    }
+                }
+            }
+
+            foreach (var commit in repo.Commits.Take(commitLimit))
+            {
+                RecurseTree(commit.Tree);
+            }
+
+            return possibleFiles.ToDictionary(pair => pair.Key, pair => pair.Value.ToList());
+        }
     }
 }

Editor/DependencyNode.cs

@@ -1,11 +1,10 @@
 using System;
+using System.Collections.Generic;
 using System.Linq;
+using UnityEngine;
 
-namespace Leap.Unity
+namespace Leap.Unity.Dependency
 {
-    using UnityEngine;
-    using System.Collections.Generic;
-
     internal class DependencyNode : DependencyNodeBase
     {
         public enum NodeKind

Editor/DependencyNodeBase.cs

@@ -1,7 +1,7 @@
 using System.Collections.Generic;
 using UnityEditor.PackageManager;
 
-namespace Leap.Unity
+namespace Leap.Unity.Dependency
 {
     /// <summary>
     /// Base class for nodes.

Editor/DependencyTree.cs

@@ -1,16 +1,15 @@
+using System;
+using System.Collections.Generic;
+using System.IO;
+using System.Linq;
+using System.Text.RegularExpressions;
+using UnityEditor;
 using UnityEditor.Compilation;
 using UnityEditor.PackageManager;
+using UnityEngine;
 
-namespace Leap.Unity
+namespace Leap.Unity.Dependency
 {
-    using UnityEngine;
-    using UnityEditor;
-    using System;
-    using System.IO;
-    using System.Linq;
-    using System.Text.RegularExpressions;
-    using System.Collections.Generic;
-
     internal class DependencyTree : ScriptableObject
     {
         [Serializable]
@@ -34,6 +33,13 @@ public class StaticAnalysisResults
             public List<string> missingGuidReferences = new List<string>();
         }
 
+        [Serializable]
+        public class MissingReferenceLookup
+        {
+            public string guid;
+            public List<string> foundFiles;
+        }
+
         /// <summary>
         /// This class is used to bundle up information required for tree generation
         /// </summary>
@@ -329,6 +335,7 @@ private static (DependencyFolderNode, Dictionary<string, DependencyNode>)? Build
         };
         public List<AssetReference> RawTree = new List<AssetReference>();
         public StaticAnalysisResults AnalysisResults;
+        public List<MissingReferenceLookup> MissingReferenceLookups = new List<MissingReferenceLookup>();
         [NonSerialized] public DependencyFolderNode RootNode;
         [NonSerialized] public Dictionary<string, DependencyNode> NodesByGuid;
 

Editor/DependencyTreeEditor.cs

@@ -1,11 +1,11 @@
-namespace Leap.Unity
-{
-    using UnityEngine;
-    using UnityEditor;
-    using System;
-    using System.Linq;
-    using System.Collections.Generic;
+using System;
+using System.Collections.Generic;
+using System.Linq;
+using UnityEditor;
+using UnityEngine;
 
+namespace Leap.Unity.Dependency
+{
     [CustomEditor(typeof(DependencyTree))]
     internal class DependencyTreeEditor : Editor
     {
@@ -261,9 +261,21 @@ bool DrawNode(DependencyNodeBase node, Predicate<DependencyNodeBase> filter)
                     selectionChanged = true;
                 }
 
+                var dependencyNode = node as DependencyNode;
+
                 GUILayout.Space(4 + (12 * indent));
-                var nodeText = $"{node.Name} ({DependencyGuiUtilities.BytesToString(node.GetSize())}){(node is DependencyNode n ? $" [{n.Dependants.Count} refs, {n.Dependencies.Count} deps]" : string.Empty)}";
+                var nodeText = $"{node.Name} ({DependencyGuiUtilities.BytesToString(node.GetSize())}){(dependencyNode != null ? $" [{dependencyNode.Dependants.Count} refs, {dependencyNode.Dependencies.Count} deps]" : string.Empty)}";
 
+                void DrawGoToButton()
+                {
+                    if (dependencyNode != null && GUILayout.Button("Go To", GUILayout.Width(50f)))
+                    {
+                        var objectToSelect = AssetDatabase.LoadAssetAtPath<UnityEngine.Object>(AssetDatabase.GUIDToAssetPath(dependencyNode.Guid));
+                        Selection.activeObject = objectToSelect;
+                        EditorGUIUtility.PingObject(objectToSelect);
+                    }
+                }
+
                 IEnumerable<DependencyNodeBase> children = Enumerable.Empty<DependencyNodeBase>();
                 if (node is DependencyFolderNode folderNode)
                 {
@@ -284,15 +296,33 @@ bool DrawNode(DependencyNodeBase node, Predicate<DependencyNodeBase> filter)
                     {
                         children = folderNode.Children;
                     }
+                    DrawGoToButton();
+                    EditorGUILayout.EndHorizontal();
+                }
+                else if (dependencyNode is { Kind: DependencyNode.NodeKind.Missing })
+                {
+                    GUI.color = DependencyGuiUtilities.GetColor(node, selectedNode);
+                    EditorGUILayout.LabelField(nodeText);
+                    DrawGoToButton();
+                    EditorGUILayout.EndHorizontal();
+                    var missingRefDetails = ((DependencyTree)target).MissingReferenceLookups.FirstOrDefault(lookup => lookup.guid == dependencyNode.Guid);
+                    foreach (var foundFile in missingRefDetails?.foundFiles ?? Enumerable.Empty<string>())
+                    {
+                        EditorGUILayout.BeginHorizontal();
+                        GUILayout.Space(20 + 4 + (12 * indent));
+                        EditorGUILayout.LabelField(foundFile);
+                        EditorGUILayout.EndHorizontal();
+                    }
+                    GUI.color = Color.white;
                 }
                 else
                 {
                     GUI.color = DependencyGuiUtilities.GetColor(node, selectedNode);
                     EditorGUILayout.LabelField(nodeText);
                     GUI.color = Color.white;
+                    DrawGoToButton();
+                    EditorGUILayout.EndHorizontal();
                 }
-
-                EditorGUILayout.EndHorizontal();
 
                 foreach (var child in (Sort switch
                          {
@@ -311,5 +341,19 @@ bool DrawNode(DependencyNodeBase node, Predicate<DependencyNodeBase> filter)
                 return selectionChanged;
             }
         }
+
+        public void DrawGitLookupMissingRefButton(string lookupRoot, int commitLimit)
+        {
+            if (GUILayout.Button("Git Lookup Missing Refs"))
+            {
+                var missingRefNodes = _missingReferencesNode.Children.Cast<DependencyNode>().ToArray();
+                var lookup = DependencyGuiUtilities.LookupMissingReferences(missingRefNodes, lookupRoot, commitLimit);
+                ((DependencyTree)target).MissingReferenceLookups = lookup.Select(pair => new DependencyTree.MissingReferenceLookup
+                {
+                    guid = pair.Key.Guid,
+                    foundFiles = pair.Value
+                }).ToList();
+            }
+        }
     }
 }