-
-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: internalize FormBuilder #2420
base: master
Are you sure you want to change the base?
Conversation
59533bc
to
550ddad
Compare
550ddad
to
176b8bd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is huge! And it paves the way to improve forms' accessibility 👍
I wonder if we could replace the callback mechanism, let's discuss that in particular before merging.
For sure! What kind API do you have in mind ? |
Not sure how we can deal with a Promise or dedicated events here (and maybe that's a bad idea). |
…hEvents Co-authored-by: David Larlet <[email protected]>
232ca9e
to
07c29ab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All 🟢
fix #2280
That's a first step, which:
L.FormBuilder
byForm
(in theory generic, but not quite) andU.FormBuilder
byMutatingForm
(knows about isDirty,inheritable
and such)There is much more room for refactor, but let's do it step by step!