Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(MM): Additional MM Endpoint and Library Filter #765

Merged
merged 5 commits into from
Dec 10, 2024

Conversation

williamputraintan
Copy link
Member

@williamputraintan williamputraintan commented Dec 9, 2024

  • Add Deletion and Patch endpoint for each metadata model (JWT email token will track the user)
  • Add is_library_none filter to Sample and Subject model to find the library-less entity

Resolve #575

Copy link
Member

@victorskl victorskl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@reisingerf
Copy link
Member

The idea is to guard those endpoints with Verified Permissions?

@williamputraintan
Copy link
Member Author

The idea is to guard those endpoints with Verified Permissions?

Yes, currently is using the same Amazon Verified Permission (AVP) which currently only has admin/no-admin. I suppose we would only need to add new policy at the AVP for these endpoints for more complex auth.

@reisingerf
Copy link
Member

Yup, all good!
As long as we can prevent uncontrolled access it's fine for now.
We'll get more detailed use cases for the new policies soon enough ;-)

@victorskl
Copy link
Member

Very soon...

@victorskl
Copy link
Member

Btw, just for my understanding/context - may be you might have discussion with @alexiswl on this.

So, the issue #578 reported by Alexis related to (fixed by) this enhancement at MM, correct?

@williamputraintan
Copy link
Member Author

Btw, just for my understanding/context - may be you might have discussion with @alexiswl on this.

So, the issue #578 reported by Alexis related to (fixed by) this enhancement at MM, correct?

Sorry, I link the wrong issue. It was supposed to be #575

@williamputraintan williamputraintan merged commit af94127 into main Dec 10, 2024
6 checks passed
@williamputraintan williamputraintan deleted the feat(mm)/CRUD-endpoint branch December 10, 2024 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

metadata-manager: Cleanup Dangling Record
3 participants