-
-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Query Parameters #382
base: master
Are you sure you want to change the base?
Conversation
680515d
to
c2d3cdd
Compare
e45cf4f
to
d77c3cb
Compare
I was thinking about this and here's my feedback to get this on production as part of Separate all query handling to its own hook It's better to separate all URL/routing logic to a separate hook. This way we achieve better separation of concern and can test it update it accordingly. This means that instead of updating three To design this we can get inspiration from Vue Router. They use a hook called We then need to move the code you written from three components to this hook. Maybe three private functions like Then there are two issues:
So we should to exactly how the other UI display components are doing. They primarily inject user selection and collection states to handle this. You can see Btw there was a linting error so it's good to run Hope this was clear, please ask if I was not clear on this and you need more information / or you do not agree @plantindesk. This is first time I collaborate someone with someone on UI source code and designing a complex feature, so things may not be well documented/explained. |
4578a0d
to
a05a600
Compare
65b10a3
to
9e8bad0
Compare
c22eab2
to
0900492
Compare
c6abab3
to
080047d
Compare
080047d
to
2f8aaf4
Compare
e5346d1
to
2f2813e
Compare
25d0d37
to
e6c52db
Compare
q
assearch
paremeterpreset
for changing thepreset
toStandard
,Strict
etccollection
that changes to user definedos
I apologize for sending pull request very late