Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICU-22968 Rearrange bits in trie values in normalization data export for ICU4X #3269

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

hsivonen
Copy link
Member

@hsivonen hsivonen commented Nov 13, 2024

This changes the format of the normalization data export for ICU4X in the way expected by unicode-org/icu4x#5813 , which makes the ICU4X normalizer significantly faster.

Checklist

  • Required: Issue filed: https://unicode-org.atlassian.net/browse/ICU-22968
  • Required: The PR title must be prefixed with a JIRA Issue number. Example: "ICU-1234 Fix xyz"
  • Required: The PR description must include the link to the Jira Issue, for example by completing the URL in the first checklist item
  • Required: Each commit message must be prefixed with a JIRA Issue number. Example: "ICU-1234 Fix xyz"
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable

@hsivonen
Copy link
Member Author

The Jira issue is in the Accepted state, so checking the checkbox here.

echeran
echeran previously approved these changes Dec 6, 2024
Copy link
Contributor

@echeran echeran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! I can re-approve and/or merge in case you need it.

icu4c/source/tools/icuexportdata/icuexportdata.cpp Outdated Show resolved Hide resolved
icu4c/source/tools/icuexportdata/icuexportdata.cpp Outdated Show resolved Hide resolved
@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • icu4c/source/tools/icuexportdata/icuexportdata.cpp is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

@hsivonen
Copy link
Member Author

Looks good, thanks! I can re-approve and/or merge in case you need it.

Thank you. I think this needs re-approval and merging now.

@hsivonen hsivonen requested a review from echeran December 11, 2024 08:38
@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • icu4c/source/tools/icuexportdata/icuexportdata.cpp is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

Copy link
Contributor

@echeran echeran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@echeran echeran merged commit 494e8cd into unicode-org:main Dec 12, 2024
94 checks passed
@hsivonen hsivonen deleted the normalizerdata branch December 13, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants