-
-
Notifications
You must be signed in to change notification settings - Fork 758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ICU-22968 Rearrange bits in trie values in normalization data export for ICU4X #3269
Conversation
The Jira issue is in the Accepted state, so checking the checkbox here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks! I can re-approve and/or merge in case you need it.
f0ee017
to
2543186
Compare
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
2543186
to
6e7953d
Compare
Hooray! The files in the branch are the same across the force-push. 😃 ~ Your Friendly Jira-GitHub PR Checker Bot |
Thank you. I think this needs re-approval and merging now. |
6e7953d
to
ee14af3
Compare
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
This changes the format of the normalization data export for ICU4X in the way expected by unicode-org/icu4x#5813 , which makes the ICU4X normalizer significantly faster.
Checklist