Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ICU-22991 Reduce unnecessary Grego calculation #3329

Merged
merged 1 commit into from
Jan 9, 2025
Merged

ICU-22991 Reduce unnecessary Grego calculation #3329

merged 1 commit into from
Jan 9, 2025

Conversation

FrankYFTang
Copy link
Contributor

Backport C++ code similification in PR 3327 to Java. Add timeToYear and dayToYear functions to skip unnecessary calculation.

Checklist

  • Required: Issue filed: ICU-22991
  • Required: The PR title must be prefixed with a JIRA Issue number. Example: "ICU-1234 Fix xyz"
  • Required: Each commit message must be prefixed with a JIRA Issue number. Example: "ICU-1234 Fix xyz"
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable

richgillam
richgillam previously approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@richgillam richgillam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOKTM. One question.

icu4j/main/core/src/main/java/com/ibm/icu/impl/Grego.java Outdated Show resolved Hide resolved
@FrankYFTang FrankYFTang requested a review from richgillam January 9, 2025 00:34
@FrankYFTang
Copy link
Contributor Author

PTAL

richgillam
richgillam approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@richgillam richgillam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for the changes.

@FrankYFTang FrankYFTang force-pushed the ICU-22991-calendar-java branch from faa81a7 to 9b4aad0 Compare January 9, 2025 00:46
@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

@FrankYFTang FrankYFTang merged commit bd50f8b into unicode-org:main Jan 9, 2025
15 checks passed
@FrankYFTang FrankYFTang deleted the ICU-22991-calendar-java branch January 9, 2025 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richgillam richgillam richgillam approved these changes

@markusicu markusicu Awaiting requested review from markusicu

Assignees

@richgillam richgillam

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FrankYFTang @richgillam