Skip to content

Commit

Permalink
FFI APIs: some gardening, GeneralCategoryGroup (#5952)
Browse files Browse the repository at this point in the history
<!--
Thank you for your pull request to ICU4X!

Reminder: try to use [Conventional
Comments](https://conventionalcomments.org/) to make comments clearer.

Please see
https://github.com/unicode-org/icu4x/blob/main/CONTRIBUTING.md for
general
information on contributing to ICU4X.
-->
  • Loading branch information
Manishearth authored Jan 6, 2025
1 parent 42f55d0 commit 1814f5f
Show file tree
Hide file tree
Showing 55 changed files with 1,347 additions and 422 deletions.
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
# Changelog

## Unreleased

- Components
- `icu_provider`
- `GeneralCategoryGroup::contains` now accepts `self` by value (unicode-org#5952)

## icu4x 2.0-beta1

- Components
Expand Down
2 changes: 1 addition & 1 deletion components/properties/src/props.rs
Original file line number Diff line number Diff line change
Expand Up @@ -527,7 +527,7 @@ impl GeneralCategoryGroup {
/// assert!(GeneralCategoryGroup::Other.contains(gc.get('\u{E007F}')));
/// assert!(!GeneralCategoryGroup::Separator.contains(gc.get('\u{E007F}')));
/// ```
pub const fn contains(&self, val: GeneralCategory) -> bool {
pub const fn contains(self, val: GeneralCategory) -> bool {
0 != (1 << (val as u32)) & self.0
}

Expand Down
5 changes: 2 additions & 3 deletions ffi/capi/bindings/c/CodePointMapData8.h

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion ffi/capi/bindings/c/CodePointSetData.h

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions ffi/capi/bindings/c/GeneralCategory.h

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

22 changes: 22 additions & 0 deletions ffi/capi/bindings/c/GeneralCategoryGroup.d.h

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

52 changes: 52 additions & 0 deletions ffi/capi/bindings/c/GeneralCategoryGroup.h

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

19 changes: 19 additions & 0 deletions ffi/capi/bindings/c/GeneralCategoryNameToGroupMapper.d.h

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

37 changes: 37 additions & 0 deletions ffi/capi/bindings/c/GeneralCategoryNameToGroupMapper.h

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

19 changes: 0 additions & 19 deletions ffi/capi/bindings/c/GeneralCategoryNameToMaskMapper.d.h

This file was deleted.

36 changes: 0 additions & 36 deletions ffi/capi/bindings/c/GeneralCategoryNameToMaskMapper.h

This file was deleted.

5 changes: 2 additions & 3 deletions ffi/capi/bindings/cpp/icu4x/CodePointMapData8.d.hpp

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

16 changes: 5 additions & 11 deletions ffi/capi/bindings/cpp/icu4x/CodePointMapData8.hpp

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion ffi/capi/bindings/cpp/icu4x/CodePointSetData.d.hpp

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 4 additions & 3 deletions ffi/capi/bindings/cpp/icu4x/CodePointSetData.hpp

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 1814f5f

Please sign in to comment.