Dedupe location names against script-root #5966
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5901
I'm not introducing script fallback (because time zone names are not meant to fall back by script), and I'm not introducing
und-Xxxx
locales, as those would increase data size (due to the other fields in the struct). Instead, I store adedupe_locale
in each data struct, which contains the locale that was deduplicated against. So forsr
, this would beru
, becausesr
->und-Cyrl
->ru
, and forru
it'd beru
as well, andru
is complete. This way, we also directly know which dedupe locale to load; if we didn't store it we'd have to load a fallbacker and step through it until we hitund
(and then use the previous value).Depends on #5967