Repository navigation
Split out names list invariants - #1611
Conversation
| # Out-of-source build. | ||
| nameslist: | ||
| name: NamesList data invariants |
There was a problem hiding this comment.
Each steps seems to do what its name suggests, but it's not totally clear to me how this all hangs together and why we need so many steps to run these tests.
Would you mind adding some comment lines here?
There was a problem hiding this comment.
Added comments. Most of this is setup from https://github.com/unicode-org/unicodetools/blob/main/docs/build.md; setting up the tools is somewhat messy.
There was a problem hiding this comment.
At some point it might make sense to factor this out into our own actions, but for now it gets copy-pasted ad nauseam.
| repository: unicode-org/unicodetools | ||
| path: unicodetools/mine/src | ||
| - name: Checkout base UnicodeData.txt | ||
| if: ${{ github.event_name == 'pull_request'}} |
There was a problem hiding this comment.
why is this condition on some of the steps? can we make it a condition on the whole task?
There was a problem hiding this comment.
Explained in the comments: this is used to turn some errors into notices, but we want to run the tests unconditionally.
| repository: unicode-org/unicodetools | ||
| path: unicodetools/mine/src | ||
| - name: Checkout base UnicodeData.txt | ||
| if: ${{ github.event_name == 'pull_request'}} |
There was a problem hiding this comment.
what if the condition is false / it's not a PR?
do we just skip checking out the base file, or do we stop the task?
| set +e | ||
| diff base-repertoire.txt merged-repertoire.txt | ||
| echo "REPERTOIRE_CHANGED=$?" >> "$GITHUB_ENV" | ||
| - name: Get the CLDR_REF from pom.xml |
There was a problem hiding this comment.
why do we need CLDR for these tests?
what is CLDR_REF? a branch name? what does it do for us here?
There was a problem hiding this comment.
I think nothing works without CLDR (and then the CLDR_REF thing is just putting it at the right revision).
Since the names list gets updated asynchronously, they can fail.