main: FIX the way to print boolean typed parser specific fields correctly in {xref,ctags} output #4174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Masatake YAMATO <[email protected]>
masatake
force-pushed
the
main--revise-xref-output
branch
from
a75b24e to
f79f782
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4174 +/- ##
=======================================
Coverage 85.92% 85.92%
=======================================
Files 241 241
Lines 59082 59111 +29
=======================================
+ Hits 50764 50792 +28
- Misses 8318 8319 +1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Masatake YAMATO <[email protected]>
NOTE: This test case is broken. In xref output, the boolean fields should be printed as '-' if the field is not set. In tags output, the value for boolean field should not be printed; if the field has an C string, the field name should be printed. The current implementation doesn't support parser specific fields typed boolean well. The following commits fix this brokenness. Signed-off-by: Masatake YAMATO <[email protected]>
…for parser specific fields Signed-off-by: Masatake YAMATO <[email protected]>
…ctly in xref output Signed-off-by: Masatake YAMATO <[email protected]>
…ctly in ctags output Signed-off-by: Masatake YAMATO <[email protected]>
Signed-off-by: Masatake YAMATO <[email protected]>
masatake
force-pushed
the
main--revise-xref-output
branch
from
f79f782 to
e7a09b3
Compare
masatake
changed the title
Signed-off-by: Masatake YAMATO <[email protected]>
…rinted (string and boolean) TODO: integer. Signed-off-by: Masatake YAMATO <[email protected]>
masatake
force-pushed
the
main--revise-xref-output
branch
from
e7a09b3 to
8df3449
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3960 is too large. This is a meaningful subset of #3960.