Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Gallery][Wasm]Tabbar-For Material Top TabBar sample Page' the tab Icon and text color is not changing for dark theme. #1032

Open
sakshi173 opened this issue Aug 13, 2023 · 7 comments · May be fixed by #1043
Open

[Gallery][Wasm]Tabbar-For Material Top TabBar sample Page' the tab Icon and text color is not changing for dark theme. #1032

sakshi173 opened this issue Aug 13, 2023 · 7 comments · May be fixed by #1043
Assignees
@Darsh0307
Labels
kind/bug Something isn't working

Comments

@sakshi173
Copy link
Contributor

Current behavior

Tabbar issue

Expected behavior

The Text and Icon color should change to black color for dark theme or the whole screen should change in black color.

How to reproduce it (as minimally and precisely as possible)

  1. Open Uno Gallery APP
  2. Tap "TabBar" from the "Component" list.
  3. Go to 'Material' section.
  4. Click on the Light/Dark theme change toggle button.
  5. Notice that the app is displaying in the Dark theme.
  6. Click on 'Show Fullscreen sample' button.
  7. Notice that the 'Tabbar Icon and text' for example 'Search'option is not displaying as per dark theme.

Workaround

No response

Works on UWP/WinUI

None

Environment

No response

NuGet package version(s)

No response

Affected platforms

WebAssembly

IDE

No response

IDE version

No response

Relevant plugins

No response

Anything else we need to know?

No response
@sakshi173 sakshi173 added kind/bug Something isn't working triage/untriaged Indicates an issue requires triaging or verification. difficulty/tbd labels Aug 13, 2023
@Youssef1313
Copy link
Member

I think this is caused by the hard-coded "LightGray" backgrounds in https://github.com/unoplatform/Uno.Gallery/blob/1127c09904e889f2265934db3d03ca1e0cbc99e6/Uno.Gallery/Uno.Gallery.Shared/Views/NestedPages/MaterialTopBarSampleNestedPage.xaml

@MartinZikmund MartinZikmund removed triage/untriaged Indicates an issue requires triaging or verification. difficulty/tbd labels Oct 23, 2023
@MartinZikmund MartinZikmund transferred this issue from unoplatform/uno Oct 23, 2023
@kazo0
Copy link
Contributor

kazo0 commented Oct 23, 2023

Would be good for @vatsashah45 / @Darsh0307 to pick up

@Darsh0307
Copy link
Contributor

@sakshi173 Will making the background colour black be the best solution for this one?

@Youssef1313
Copy link
Member

Youssef1313 commented Nov 1, 2023 •
edited
Loading

@Darsh0307 I think it should depend on the theme.

@Darsh0307
Copy link
Contributor

But @Youssef1313 if i see we can change the colour of the
Screenshot 2023-11-01 at 10 44 09 AM

@kazo0
Copy link
Contributor

kazo0 commented Nov 2, 2023 •
edited
Loading

@Darsh0307 let's change those to {ThemeResource SurfaceBrush}

And the FontIcons/TextBlocks should use OnSurfaceBrush as their foregrounds

@Darsh0307 Darsh0307 linked a pull request Nov 3, 2023 that will close this issue
Open
7 tasks
@Darsh0307
Copy link
Contributor

https://teams.microsoft.com/l/message/19:[email protected]/1699034108277?tenantId=a297d6c0-b635-41a3-b1e3-558efe71e413&groupId=f55cdec8-036b-4efa-8e1a-c4129ba9bf12&parentMessageId=1699034108277&teamName=Uno%20Platform&channelName=Collab%20Lounge&createdTime=1699034108277

This is a blocker for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Darsh0307 Darsh0307

Labels
kind/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Background for Tabbar Icon unoplatform/Uno.Gallery
5 participants
@MartinZikmund @kazo0 @Youssef1313 @sakshi173 @Darsh0307