fix: Background for Tabbar Icon #1043
Conversation
Uno.Gallery/Uno.Gallery.Shared/Views/NestedPages/MaterialTopBarSampleNestedPage.xaml
Outdated
Show resolved
Hide resolved
|
Darsh Patel seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://white-field-08c5cf00f-1043.eastus2.3.azurestaticapps.net |
Uno.Gallery/Uno.Gallery.Shared/Views/NestedPages/MaterialTopBarSampleNestedPage.xaml
Outdated
Show resolved
Hide resolved
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://white-field-08c5cf00f-1043.eastus2.3.azurestaticapps.net |
| @@ -42,32 +42,32 @@ | |||
| <Grid x:Name="Home" Visibility="Collapsed"> | |||
| <Border Background="LightGray"> | |||
There was a problem hiding this comment.
This Background needs to be set to {ThemeResource SurfaceBrush} instead of LightGray
| <FontIcon Glyph="{StaticResource HomeIcon}" /> | ||
| <TextBlock Text="Home" TextAlignment="Center" /> | ||
| <FontIcon Foreground="{ThemeResource OnSurfaceBrush}" Glyph="{StaticResource HomeIcon}" /> | ||
| <TextBlock Foreground="{ThemeResource OnSurfaceBrush}" Text="Home" TextAlignment="Center" /> | ||
| </StackPanel> | ||
| </Border> | ||
| </Grid> | ||
| <Grid x:Name="Search" Visibility="Collapsed"> | ||
| <Border Background="LightGray"> |
There was a problem hiding this comment.
This Background needs to be set to {ThemeResource SurfaceBrush} instead of LightGray
| <FontIcon Glyph="{StaticResource SearchIcon}" /> | ||
| <TextBlock Text="Search" TextAlignment="Center" /> | ||
| <FontIcon Foreground="{ThemeResource OnSurfaceBrush}" Glyph="{StaticResource SearchIcon}" /> | ||
| <TextBlock Foreground="{ThemeResource OnSurfaceBrush}" Text="Search" TextAlignment="Center" /> | ||
| </StackPanel> | ||
| </Border> | ||
| </Grid> | ||
| <Grid x:Name="Support" Visibility="Collapsed"> | ||
| <Border Background="LightGray"> |
There was a problem hiding this comment.
This Background needs to be set to {ThemeResource SurfaceBrush} instead of LightGray
| <TextBlock Text="Support" TextAlignment="Center" /> | ||
| <StackPanel HorizontalAlignment="Center" VerticalAlignment="Center"> | ||
| <FontIcon Foreground="{ThemeResource OnSurfaceBrush}" Glyph="{StaticResource SupportIcon}" /> | ||
| <TextBlock Foreground="{ThemeResource OnSurfaceBrush}" Text="Support" TextAlignment="Center" /> | ||
| </StackPanel> | ||
| </Border> | ||
| </Grid> | ||
| <Grid x:Name="About" Visibility="Collapsed"> | ||
| <Border Background="LightGray"> |
There was a problem hiding this comment.
This Background needs to be set to {ThemeResource SurfaceBrush} instead of LightGray
GitHub Issue (If applicable): closes #1032
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Tabbar-For Material Top TabBar sample Page' the tab Icon and text color is not changing for dark theme
What is the new behavior?
The Text and Icon color should change to black color for dark theme or the whole screen should change in black color.
PR Checklist
Please check if your PR fulfills the following requirements:
Other information
Internal Issue (If applicable):