Sets refid correctly for target nodes (#233)

Fixes #229
useblocks · Apr 16, 2021 · adc8018 · adc8018
1 parent 99dac3d
commit adc8018
Show file tree

Hide file tree

Showing 20 changed files with 4 additions and 3 deletions.
diff --git a/.gitignore b/.gitignore
@@ -16,3 +16,5 @@ _build
 .doctrees
 docs/github_images/
 .eggs/
+
+docs/_images/need_pie_*.png
diff --git a/docs/_images/need_pie_10fbc.png b/docs/_images/need_pie_10fbc.png
diff --git a/docs/_images/need_pie_132a2.png b/docs/_images/need_pie_132a2.png
diff --git a/docs/_images/need_pie_1bc0e.png b/docs/_images/need_pie_1bc0e.png
diff --git a/docs/_images/need_pie_2c3ed.png b/docs/_images/need_pie_2c3ed.png
diff --git a/docs/_images/need_pie_3d372.png b/docs/_images/need_pie_3d372.png
diff --git a/docs/_images/need_pie_47238.png b/docs/_images/need_pie_47238.png
diff --git a/docs/_images/need_pie_64ad3.png b/docs/_images/need_pie_64ad3.png
diff --git a/docs/_images/need_pie_76ebe.png b/docs/_images/need_pie_76ebe.png
diff --git a/docs/_images/need_pie_873ef.png b/docs/_images/need_pie_873ef.png
diff --git a/docs/_images/need_pie_88777.png b/docs/_images/need_pie_88777.png
diff --git a/docs/_images/need_pie_ca835.png b/docs/_images/need_pie_ca835.png
diff --git a/docs/_images/need_pie_d0d45.png b/docs/_images/need_pie_d0d45.png
diff --git a/docs/_images/need_pie_d192f.png b/docs/_images/need_pie_d192f.png
diff --git a/docs/_images/need_pie_dbfaf.png b/docs/_images/need_pie_dbfaf.png
diff --git a/docs/_images/need_pie_df318.png b/docs/_images/need_pie_df318.png
diff --git a/docs/_images/need_pie_df9e6.png b/docs/_images/need_pie_df9e6.png
diff --git a/docs/_images/need_pie_e2e07.png b/docs/_images/need_pie_e2e07.png
diff --git a/docs/_images/need_pie_fd3f3.png b/docs/_images/need_pie_fd3f3.png
diff --git a/sphinxcontrib/needs/api/need.py b/sphinxcontrib/needs/api/need.py
@@ -132,7 +132,7 @@ def run():
             id=need_id, regex=env.app.config.needs_id_regex))
 
     # Calculate target id, to be able to set a link back
-    target_node = nodes.target('', '', ids=[need_id])
+    target_node = nodes.target('', '', ids=[need_id],  refid=need_id)
 
     # Handle status
     # Check if status is in needs_statuses. If not raise an error.
@@ -307,7 +307,7 @@ def run():
         style_classes.append(style)
 
     node_need = sphinxcontrib.needs.directives.need.Need(
-        '', classes=style_classes, ids=[need_id])
+        '', classes=style_classes, ids=[need_id], refid=need_id)
 
     # Render rst-based content and add it to the need-node
 
@@ -377,7 +377,6 @@ def _read_in_links(links_string):
             else:
                 links.append(link.strip())
 
-
         # This may have cut also dynamic function strings, as they can contain , as well.
         # So let put them together again
         # ToDo: There may be a smart regex for the splitting. This would avoid this mess of code...