Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Public-sans: Update Node LTS #282

Merged
merged 3 commits into from
Nov 22, 2023
Merged

Public-sans: Update Node LTS #282

merged 3 commits into from
Nov 22, 2023

Conversation

mahoneycm
Copy link
Contributor

@mahoneycm mahoneycm commented Oct 19, 2023

Summary

Set node 18 as the default. Updated .nvmrc file from 16→18, which is the current LTS version.

Breaking change

This is not a breaking change.

Related issue

Closes #281 .

Related pull requests

Related to:
uswds/uswds-site#2304
uswds/uswds#5560

Preview link

Public-sans →

Problem statement

Support for node 16 is going to stop on CloudGov pages.

Solution

  1. Update .nvmrc to 18.
  2. Run npm audit fix.
  3. Update ruby gems.

Testing and review

  1. Run npm install and confirm no errors.
  2. Run npm run build and confirm no errors.
  3. Run npm run start and confirm no errors.
  4. Run npm run serve and confirm site builds as expected.

Checklist

  • No errors when installing, building, starting, or serving the site
  • No regressions on public-sans demo site

Gem updates

Indented gems are sub dependencies

Gem name Previous version New version
addressable 2.8.0 2.8.5
public_suffix ≥ 2.0.2, < 5.0 ≥ 2.0.2, < 6.0
concurrent-ruby 1.1.10 1.2.2
ffi 1.15.5 1.16.3
google-protobuf - 3.24.4
i18n 1.10.0 1.14.1
jekyll 4.2.2 4.3.2
- jekyll-sass-converter ~> 2.0 ≥ 2.0, <4.0
- kramdown ~>2.3 ~> 2.3, ≥ 2.3.1
- mercenary ~> 0.4.0 ≥ 3.0, < 0.5
- rouge ~> 3.0 ≥ 3.2, < 5.0
- terminal-table ~> 2.0 ≥ 1.8, <4.0
- webrick - ~> 1.7
jekyll-sass-converter 2.2.0 3.0.0
- sassc > 2.0.1, < 0.33 -
- sass-embedded - ~> 1.54
liquid 4.0.3 4.0.4
listen 3.7.1 3.8.0
public_suffix 4.0.7 5.0.3
rack 2.2.6.2 2.2.8
rb-fsevent 0.11.1 0.11.2
rexml 3.2.5 3.2.6
rouge 3.28.0 4.1.3
sassc 2.4.0 -
- ffi ~> 1.69 -
sass-embedded - 1.69.4
- google-protobuf - ~> 3.23
- rake - ≥ 13.0.0
terminal-table 2.0.0 3.0.2
- unicode-display_width ~> 1.1, ≥ 1.1.1 ≥ 1.1.1, < 3
thin 1.8.1 1.8.2
unicode-display_width 1.8.0 2.5.0
webrick 1.7.0 1.8.1

@mahoneycm mahoneycm requested a review from mejiaj October 19, 2023 15:12
Copy link
Contributor

@mejiaj mejiaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need a new issue for LTS 20.

@mejiaj mejiaj merged commit 9088d43 into develop Nov 22, 2023
@mejiaj mejiaj deleted the cm-update-node-lts-18 branch November 22, 2023 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Public sans - Dependencies: Use node LTS 18
2 participants