Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MPU implementation #4

Closed
wants to merge 2 commits into from
Closed

MPU implementation #4

wants to merge 2 commits into from

Conversation

mzqan
Copy link
Contributor

@mzqan mzqan commented Nov 10, 2024

No description provided.

Copy link
Member

@Akashem06 Akashem06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, a few changes. Please run
scons format
scons lint
scons

to auto format/lint your files. and build them. Please add the return comments in your header file! Nice work

libraries/ms-common/src/arm/mpu.c Outdated Show resolved Hide resolved
libraries/ms-common/src/arm/mpu.c Show resolved Hide resolved
libraries/ms-common/src/arm/mpu.c Outdated Show resolved Hide resolved
libraries/ms-common/inc/mpu.h Show resolved Hide resolved
libraries/ms-common/inc/mpu.h Show resolved Hide resolved
libraries/ms-common/inc/mpu.h Show resolved Hide resolved
libraries/ms-common/src/arm/mpu.c Outdated Show resolved Hide resolved
libraries/ms-common/src/arm/mpu.c Outdated Show resolved Hide resolved
@mzqan mzqan closed this Nov 14, 2024
@Akashem06 Akashem06 deleted the mpu_implementation branch November 24, 2024 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants