-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] clang-format C++ code and add to linting #2244
Merged
Merged
+2,458
−2,437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icfaust
force-pushed
the
dev/clang_format
branch
from
January 7, 2025 11:49
9915cea
to
b6390a7
Compare
icfaust
changed the title
[CI] add clang-formatting to C++ code
[CI] clang-format C++ code and add to linting
Jan 7, 2025
icfaust
changed the title
[CI] clang-format C++ code and add to linting
[CI] clang-format C++ code in Jan 7, 2025
onedal/
and add to linting
…learn-intelex into dev/clang_format
/intelci: run |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Flags with carried forward coverage won't be shown. Click here to find out more. |
icfaust
changed the title
[CI] clang-format C++ code in
[CI] clang-format C++ code and add to linting
Jan 7, 2025
onedal/
and add to linting
/intelci: run |
Alexsandruss
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
the
_clang_format
file is used bygenerator/gen_daal4py.py
though it is not stated anywhere. However, this is not used to format the codebase. Therefore file is moved with the daal4py code and now also formats it. A general.clang-format
is added so that clang-formatting can be applied to specific folders without applying everywhere. Theonedal/
folder contains its own.clang-format
and is now applied to the C++ code there. It is used, applied, and is now included in the.pre-commit-config.yaml
. It will be tested going forward likeblack
andisort
.Majority of the changes are due to applying clang-format.
PR should start as a draft, then move to ready for review state after CI is passed and all applicable checkboxes are closed.
This approach ensures that reviewers don't spend extra time asking for regular requirements.
You can remove a checkbox as not applicable only if it doesn't relate to this PR in any way.
For example, PR with docs update doesn't require checkboxes for performance while PR with any change in actual code should have checkboxes and justify how this code change is expected to affect performance (or justification should be self-evident).
Checklist to comply with before moving PR from draft:
PR completeness and readability
Testing
Performance