Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update zxlib #5

Open
wants to merge 11 commits into
base: develop
Choose a base branch
from

Remove outdated menu entries, improve menu test

8c4c061
Select commit
Loading
Failed to load commit list.
Open

Update zxlib #5

Remove outdated menu entries, improve menu test
8c4c061
Select commit
Loading
Failed to load commit list.
GitHub Advanced Security / CodeQL succeeded Dec 31, 2024 in 6s

33 new alerts

New alerts in code changed by this pull request

  • 6 warnings
  • 27 notes

Alerts not introduced by this pull request might have been detected because the code changes were too large.

See annotations below for details.

View all branch alerts.

Annotations

Check notice on line 63 in deps/ledger-zxlib/app/ui/view_internal.h

See this annotation in the file changed.

Code scanning / CodeQL

Unused static variable Note

Static variable review_key is never read.

Check notice on line 64 in deps/ledger-zxlib/app/ui/view_internal.h

See this annotation in the file changed.

Code scanning / CodeQL

Unused static variable Note

Static variable review_txvalue is never read.

Check notice on line 65 in deps/ledger-zxlib/app/ui/view_internal.h

See this annotation in the file changed.

Code scanning / CodeQL

Unused static variable Note

Static variable review_addrvalue is never read.

Check notice on line 69 in deps/ledger-zxlib/app/ui/view_internal.h

See this annotation in the file changed.

Code scanning / CodeQL

Unused static variable Note

Static variable shortcut_key is never read.

Check notice on line 78 in deps/ledger-zxlib/app/ui/view_internal.h

See this annotation in the file changed.

Code scanning / CodeQL

Unused static variable Note

Static variable review_keyconfig is never read.

Check notice on line 79 in deps/ledger-zxlib/app/ui/view_internal.h

See this annotation in the file changed.

Code scanning / CodeQL

Unused static variable Note

Static variable review_configvalue is never read.

Check notice on line 80 in deps/ledger-zxlib/app/ui/view_internal.h

See this annotation in the file changed.

Code scanning / CodeQL

Unused static variable Note

Static variable review_skip_key is never read.

Check notice on line 81 in deps/ledger-zxlib/app/ui/view_internal.h

See this annotation in the file changed.

Code scanning / CodeQL

Unused static variable Note

Static variable review_skip_value is never read.

Check notice on line 82 in deps/ledger-zxlib/app/ui/view_internal.h

See this annotation in the file changed.

Code scanning / CodeQL

Unused static variable Note

Static variable review_skip_key_msg is never read.

Check notice on line 83 in deps/ledger-zxlib/app/ui/view_internal.h

See this annotation in the file changed.

Code scanning / CodeQL

Unused static variable Note

Static variable review_skip_value_msg is never read.

Check notice on line 84 in deps/ledger-zxlib/app/ui/view_internal.h

See this annotation in the file changed.

Code scanning / CodeQL

Unused static variable Note

Static variable review_skip_key_msg_2 is never read.

Check notice on line 85 in deps/ledger-zxlib/app/ui/view_internal.h

See this annotation in the file changed.

Code scanning / CodeQL

Unused static variable Note

Static variable review_skip_value_msg_2 is never read.

Check notice on line 93 in deps/ledger-zxlib/app/ui/view_internal.h

See this annotation in the file changed.

Code scanning / CodeQL

Unused static variable Note

Static variable review_msgKey is never read.

Check notice on line 94 in deps/ledger-zxlib/app/ui/view_internal.h

See this annotation in the file changed.

Code scanning / CodeQL

Unused static variable Note

Static variable review_msgValue is never read.

Check notice on line 97 in deps/ledger-zxlib/app/ui/view_internal.h

See this annotation in the file changed.

Code scanning / CodeQL

Unused static variable Note

Static variable shortcut_value is never read.

Check notice on line 113 in deps/ledger-zxlib/app/ui/view_internal.h

See this annotation in the file changed.

Code scanning / CodeQL

FIXME comment Note

FIXME comment: Wait to be fixed on SDK:

Check warning on line 90 in deps/ledger-zxlib/app/ui/view_nano.c

See this annotation in the file changed.

Code scanning / CodeQL

Comparison result is always the same Warning

Comparison is always false because extraScreens <= 0.

Check warning on line 113 in deps/ledger-zxlib/app/ui/view_nano.c

See this annotation in the file changed.

Code scanning / CodeQL

Comparison result is always the same Warning

Comparison is always false because extraScreens <= 0.

Check notice on line 310 in deps/ledger-zxlib/app/ui/view_x.c

See this annotation in the file changed.

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.

Check notice on line 673 in deps/ledger-zxlib/app/ui/view_x.c

See this annotation in the file changed.

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.

Check notice on line 1184 in deps/ledger-zxlib/include/utf8.h

See this annotation in the file changed.

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.

Check notice on line 1241 in deps/ledger-zxlib/include/utf8.h

See this annotation in the file changed.

Code scanning / CodeQL

Complex condition Note

Complex condition: too many logical operations in this expression.

Check notice on line 1250 in deps/ledger-zxlib/include/utf8.h

See this annotation in the file changed.

Code scanning / CodeQL

Complex condition Note

Complex condition: too many logical operations in this expression.

Check notice on line 1254 in deps/ledger-zxlib/include/utf8.h

See this annotation in the file changed.

Code scanning / CodeQL

Complex condition Note

Complex condition: too many logical operations in this expression.

Check notice on line 1396 in deps/ledger-zxlib/include/utf8.h

See this annotation in the file changed.

Code scanning / CodeQL

Complex condition Note

Complex condition: too many logical operations in this expression.