Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat (deploy): Port localhost deployment code #2258

Merged
merged 6 commits into from
Dec 3, 2024
Merged

Feat (deploy): Port localhost deployment code #2258

merged 6 commits into from
Dec 3, 2024

Conversation

OjusWiZard
Copy link
Member

@OjusWiZard OjusWiZard commented Sep 26, 2024 •
edited
Loading

Proposed changes

Porting the code from Pearl to here that runs an agent on local host system without docker.

Types of changes

What types of changes does your code introduce? (A breaking change is a fix or feature that would cause existing functionality and APIs to not work as expected.)
Put an x in the box that applies

  • Non-breaking fix (non-breaking change which fixes an issue)
  • Breaking fix (breaking change which fixes an issue)
  • Non-breaking feature (non-breaking change which adds functionality)
  • Breaking feature (breaking change which adds functionality)
  • Refactor (non-breaking change which changes implementation)
  • Messy (mixture of the above - requires explanation!)

Checklist

Put an x in the boxes that apply.

  • I have read the CONTRIBUTING doc
  • I am making a pull request against the main branch (left side). Also you should start your branch off our main.
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have locally run services that could be impacted and they do not present failures derived from my changes
  • Public-facing documentation has been updated with the changes affected by this PR. Even if the provided contents are not in their final form, all significant information must be included.
  • Any backwards-incompatible/breaking change has been clearly documented in the upgrading document.

Further comments

@OjusWiZard OjusWiZard force-pushed the feat/non-docker branch 3 times, most recently from 9604d73 to 9854546 Compare September 26, 2024 15:40
8ball030
8ball030 reviewed Sep 26, 2024
View reviewed changes
Copy link
Collaborator

@8ball030 8ball030 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super excited for this one

deployments/Dockerfiles/tendermint/app.py Outdated
@@ -154,7 +154,7 @@ def __init__(self, logger: logging.Logger, dump_dir: Optional[Path] = None) -> N

self.resets = 0
self.logger = logger
self.dump_dir = dump_dir or Path("/tm_state")
self.dump_dir = dump_dir or Path(os.environ["TMSTATE"] or "/tm_state")
Copy link
Collaborator

@8ball030 8ball030 Sep 26, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add this to the docs somewhere btw?
Also would be nice to able to set an alias for the agent.
It's in aea fetch AGENT --alias command group

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure! do you know any good place to add the docs? I'm guessing the docstring of def create_server()?

@OjusWiZard OjusWiZard changed the base branch from main to feat/local-deployment September 26, 2024 18:32
Adamantios
Adamantios reviewed Sep 27, 2024
View reviewed changes
autonomy/cli/helpers/deployment.py Outdated Show resolved Hide resolved
autonomy/cli/helpers/deployment.py Outdated Show resolved Hide resolved
autonomy/cli/helpers/deployment.py Outdated Show resolved Hide resolved
autonomy/cli/helpers/deployment.py Outdated Show resolved Hide resolved
autonomy/cli/helpers/deployment.py Outdated Show resolved Hide resolved
autonomy/deploy/generators/localhost/base.py Outdated Show resolved Hide resolved
autonomy/deploy/generators/localhost/base.py Show resolved Hide resolved
autonomy/deploy/generators/localhost/base.py Outdated Show resolved Hide resolved
autonomy/deploy/generators/localhost/utils.py Outdated Show resolved Hide resolved
deployments/Dockerfiles/tendermint/app.py Outdated Show resolved Hide resolved
@OjusWiZard OjusWiZard changed the base branch from feat/local-deployment to main September 27, 2024 16:38
@OjusWiZard OjusWiZard force-pushed the feat/non-docker branch 6 times, most recently from 3c1f5aa to 2d752cf Compare October 1, 2024 15:06
@OjusWiZard OjusWiZard changed the title WIP (deploy): Port localhost deployment code Feat (deploy): Port localhost deployment code Oct 1, 2024
@OjusWiZard OjusWiZard requested a review from 0xArdi October 1, 2024 15:36
@OjusWiZard OjusWiZard closed this Oct 3, 2024
@OjusWiZard OjusWiZard deleted the feat/non-docker branch October 3, 2024 11:02
@OjusWiZard OjusWiZard restored the feat/non-docker branch October 4, 2024 09:59
@OjusWiZard OjusWiZard reopened this Oct 4, 2024
@OjusWiZard OjusWiZard force-pushed the feat/non-docker branch 10 times, most recently from ef6e9ed to 11e525f Compare October 28, 2024 18:15
Adamantios
Adamantios previously approved these changes Nov 14, 2024
View reviewed changes
github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 28, 2024
View reviewed changes
autonomy/deploy/generators/localhost/tendermint/app.py
tendermint_node.start()
return jsonify({"message": "Reset successful.", "status": True}), 200
except Exception as e: # pylint: disable=W0703
return jsonify({"message": f"Reset failed: {e}", "status": False}), 200

Check warning

Code scanning / CodeQL

Information exposure through an exception Medium

Stack trace information
Loading
flows to this location and may be exposed to an external user.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's already open-source bro what are you talking about?1

autonomy/deploy/generators/localhost/tendermint/app.py
return jsonify({"app_hash": app_hash_}), res.status_code
except Exception as e: # pylint: disable=W0703
return (
jsonify({"error": f"Could not get the app hash: {str(e)}"}),

Check warning

Code scanning / CodeQL

Information exposure through an exception Medium

Stack trace information
Loading
flows to this location and may be exposed to an external user.
autonomy/deploy/generators/localhost/tendermint/app.py
tendermint_node.start()
return jsonify({"message": "Reset successful.", "status": True}), 200
except Exception as e: # pylint: disable=W0703
return jsonify({"message": f"Reset failed: {e}", "status": False}), 200

Check warning

Code scanning / CodeQL

Information exposure through an exception Medium

Stack trace information
Loading
flows to this location and may be exposed to an external user.
@OjusWiZard OjusWiZard force-pushed the feat/non-docker branch 3 times, most recently from 32a9115 to 5e209b3 Compare November 28, 2024 15:23
@OjusWiZard
fix: e2e tests
8af24f7 
Signed-off-by: OjusWiZard <[email protected]>
@OjusWiZard OjusWiZard merged commit d3fddd4 into valory-xyz:main Dec 3, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@8ball030 8ball030 8ball030 left review comments

@Adamantios Adamantios Adamantios approved these changes

@0xArdi 0xArdi Awaiting requested review from 0xArdi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@OjusWiZard @Adamantios @8ball030