Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken links #2293

Merged
merged 8 commits into from
Jan 14, 2025
Merged

Fix broken links #2293

merged 8 commits into from
Jan 14, 2025

Conversation

nrosa-valory
Copy link
Collaborator

Proposed changes

  1. Adjust the workflow to use the same command as the one used in the docs repo to avoid the situation where it passes CI checks on this repo but is blocked when we try to release the documentation.
  2. It fixes the broken links that are blocking the PR on the docs repo

Fixes

It fixes some broken links

Types of changes

What types of changes does your code introduce? (A breaking change is a fix or feature that would cause existing functionality and APIs to not work as expected.)
Put an x in the box that applies

  • Non-breaking fix (non-breaking change which fixes an issue)
  • Breaking fix (breaking change which fixes an issue)
  • Non-breaking feature (non-breaking change which adds functionality)
  • Breaking feature (breaking change which adds functionality)
  • Refactor (non-breaking change which changes implementation)
  • Messy (mixture of the above - requires explanation!)

Checklist

Put an x in the boxes that apply.

  • I have read the CONTRIBUTING doc
  • I am making a pull request against the main branch (left side). Also you should start your branch off our main.
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have locally run services that could be impacted and they do not present failures derived from my changes
  • Public-facing documentation has been updated with the changes affected by this PR. Even if the provided contents are not in their final form, all significant information must be included.
  • Any backwards-incompatible/breaking change has been clearly documented in the upgrading document.

Further comments

n/a

@nrosa-valory nrosa-valory merged commit aa04466 into main Jan 14, 2025
23 of 25 checks passed
@nrosa-valory nrosa-valory deleted the doc/general branch January 14, 2025 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants