handle feedback

versatica · Dec 19, 2023 · 8841ec4 · 8841ec4
1 parent 1277f5c
commit 8841ec4
Show file tree

Hide file tree

Showing 3 changed files with 29 additions and 16 deletions.
diff --git a/worker/include/Utils.hpp b/worker/include/Utils.hpp
@@ -23,17 +23,7 @@ namespace Utils
 
 		static void GetAddressInfo(const struct sockaddr* addr, int& family, std::string& ip, uint16_t& port);
 
-		static size_t GetAddressLen(const struct sockaddr* addr)
-		{
-			if (addr->sa_family == AF_INET)
-			{
-				return sizeof(struct sockaddr_in);
-			}
-			else
-			{
-				return sizeof(struct sockaddr_in6);
-			}
-		}
+		static size_t GetAddressLen(const struct sockaddr* addr);
 
 		static bool CompareAddresses(const struct sockaddr* addr1, const struct sockaddr* addr2)
 		{

diff --git a/worker/src/DepLibUring.cpp b/worker/src/DepLibUring.cpp
@@ -78,22 +78,22 @@ inline static void onFdEvent(uv_poll_t* handle, int status, int events)
 			continue;
 		}
 
-		// Failed SQE.
-		if (cqe->res < 0)
+		// Successfull SQE.
+		if (cqe->res >= 0)
 		{
 			if (userData->cb)
 			{
-				(*userData->cb)(false);
+				(*userData->cb)(true);
 				delete userData->cb;
 				userData->cb = nullptr;
 			}
 		}
-		// Successfull SQE.
+		// Failed SQE.
 		else
 		{
 			if (userData->cb)
 			{
-				(*userData->cb)(true);
+				(*userData->cb)(false);
 				delete userData->cb;
 				userData->cb = nullptr;
 			}

diff --git a/worker/src/Utils/IP.cpp b/worker/src/Utils/IP.cpp
@@ -91,6 +91,29 @@ namespace Utils
 		ip.assign(ipBuffer);
 	}
 
+	size_t IP::GetAddressLen(const struct sockaddr* addr)
+	{
+		MS_TRACE();
+
+		switch (addr->sa_family)
+		{
+			case AF_INET:
+			{
+				return sizeof(struct sockaddr_in);
+			}
+
+			case AF_INET6:
+			{
+				return sizeof(struct sockaddr_in6);
+			}
+
+			default:
+			{
+				MS_ABORT("unknown network family: %d", static_cast<int>(addr->sa_family));
+			}
+		}
+	}
+
 	void IP::NormalizeIp(std::string& ip)
 	{
 		MS_TRACE();