Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for playout-delay extension #1412

Merged
merged 4 commits into from
Jun 25, 2024

Conversation

DavidNegro
Copy link
Contributor

http://www.webrtc.org/experiments/rtp-hdrext/playout-delay

Like video-orientation extension, an SFU must proxy this extension to the consumers or discard it if the consumer doesn't support this extension.

http://www.webrtc.org/experiments/rtp-hdrext/playout-delay

Like video-orientation extension, an SFU must proxy this extension
to the consumers or discard it if the consumer doesn't support this
extension.
worker/src/RTC/RtpPacket.cpp Show resolved Hide resolved
worker/include/RTC/RtpPacket.hpp Show resolved Hide resolved
@ibc
Copy link
Member

ibc commented Jun 21, 2024

Thanks. I won't be able to properly review this PR until next week.

BTW we also need changes in mediasoup-client (see RtpHeaderExtensionUri in RtpParameters.ts in mediasoup-client project).

DavidNegro added a commit to DavidNegro/mediasoup-client that referenced this pull request Jun 21, 2024
worker/src/RTC/Consumer.cpp Outdated Show resolved Hide resolved
worker/src/RTC/Producer.cpp Show resolved Hide resolved
worker/src/RTC/Producer.cpp Outdated Show resolved Hide resolved
worker/src/RTC/RtpDictionaries/RtpHeaderExtensionUri.cpp Outdated Show resolved Hide resolved
worker/src/RTC/RtpDictionaries/RtpHeaderExtensionUri.cpp Outdated Show resolved Hide resolved
@ibc
Copy link
Member

ibc commented Jun 24, 2024

@DavidNegro will you address feedback given above?

@DavidNegro
Copy link
Contributor Author

@DavidNegro will you address feedback given above?

Yes, working on it!

node/src/supportedRtpCapabilities.ts Outdated Show resolved Hide resolved
rust/src/supported_rtp_capabilities.rs Show resolved Hide resolved
@ibc ibc merged commit a16f047 into versatica:v3 Jun 25, 2024
@ibc
Copy link
Member

ibc commented Jun 25, 2024

Thanks. Released in mediasoup-node 3.14.8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants