Adding a 'defined' variant of the theme #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pushqrdx
reviewed
Nov 23, 2020
There was a problem hiding this comment.
if the only change is VertSplit, and few other colors, i'd suggest adding them in the original colorscheme file with a toggle variable like here then you can check if user specified the "defined" variable and apply the changes
| @@ -1,9 +1,9 @@ | |||
| <div align="center"> | |||
|
|
|||
|  | |||
There was a problem hiding this comment.
The read me should be adding info about the variant instead of replacing the original
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added cinnabar-defined.vim.
Cinnabar-defined
Cinnabar defined is the same look and feel as the original cinnabar theme. The only difference is a more defined VertSplit group. In this version of the theme the VertSplit is a grey rather than the same black as the background.