RHEL-69075: Formatting vioinput driver with clang-format [HLK-SANITY] #1245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kostyanf14
reviewed
Jan 7, 2025
Comment on lines
+335
to
+343
| { | ||
| sprintf_s(buffer, sizeof(buffer), "%02x", pDescriptor[i]); | ||
| i++; | ||
| break; | ||
| } |
There was a problem hiding this comment.
@YanVugenfirer Do we need {} in case?
There was a problem hiding this comment.
It is not really needed, but it was here before. No reason to have it here as there are no local variables.
Comment on lines
+362
to
+367
| { | ||
| TraceEvents(TRACE_LEVEL_INFORMATION, DBG_INIT, "Got axis-based vertical wheel\n"); | ||
| pMouseDesc->uFlags |= CLASS_MOUSE_SUPPORTS_REL_WHEEL; | ||
| pMouseDesc->uFlags |= CLASS_MOUSE_HAS_V_WHEEL; | ||
| break; | ||
| } |
There was a problem hiding this comment.
Can be removed. But I think better in another PR
vioinput/sys/HidTablet.c
Outdated
Comment on lines
867
to
878
| pTabletDesc->Common.cbHidReportSize = 1 + // report ID | ||
| sizeof(INPUT_CLASS_TABLET_SLOT) * pTabletDesc->uMaxContacts + // max contacts | ||
| // * per-contact | ||
| // packet. See | ||
| // INPUT_CLASS_TABLET_SLOT | ||
| // and | ||
| // INPUT_CLASS_TABLET | ||
| // for layout | ||
| // details. | ||
| 1 + // Actual contact count | ||
| (pTabletDesc->bMscTs ? sizeof(LONG) : 0) // Scan time | ||
| ; |
There was a problem hiding this comment.
@YanVugenfirer Maybe rewrite this part or disable the format?
There was a problem hiding this comment.
Probably better re-write
vioinput/sys/KeyMap.c
Outdated
Comment on lines
36
to
40
| static const ULONG ReportCodeToUsageCodeTable[] = { | ||
| /* KEY_RESERVED */ | ||
| 0x00, | ||
| /* KEY_ESC */ 0x29, | ||
| /* KEY_1 */ 0x1E, |
There was a problem hiding this comment.
The same problem as in vioserial
vioinput/sys/Hid.c
Outdated
| 0x01, // number of HID class descriptors | ||
| { | ||
| // DescriptorList[0] | ||
| 0x22, // report descriptor type 0x22 |
There was a problem hiding this comment.
Indentation issues again
Comment on lines
+335
to
+343
| { | ||
| sprintf_s(buffer, sizeof(buffer), "%02x", pDescriptor[i]); | ||
| i++; | ||
| break; | ||
| } |
There was a problem hiding this comment.
It is not really needed, but it was here before. No reason to have it here as there are no local variables.
Comment on lines
+362
to
+367
| { | ||
| TraceEvents(TRACE_LEVEL_INFORMATION, DBG_INIT, "Got axis-based vertical wheel\n"); | ||
| pMouseDesc->uFlags |= CLASS_MOUSE_SUPPORTS_REL_WHEEL; | ||
| pMouseDesc->uFlags |= CLASS_MOUSE_HAS_V_WHEEL; | ||
| break; | ||
| } |
There was a problem hiding this comment.
Can be removed. But I think better in another PR
vioinput/sys/HidTablet.c
Outdated
Comment on lines
867
to
878
| pTabletDesc->Common.cbHidReportSize = 1 + // report ID | ||
| sizeof(INPUT_CLASS_TABLET_SLOT) * pTabletDesc->uMaxContacts + // max contacts | ||
| // * per-contact | ||
| // packet. See | ||
| // INPUT_CLASS_TABLET_SLOT | ||
| // and | ||
| // INPUT_CLASS_TABLET | ||
| // for layout | ||
| // details. | ||
| 1 + // Actual contact count | ||
| (pTabletDesc->bMscTs ? sizeof(LONG) : 0) // Scan time | ||
| ; |
There was a problem hiding this comment.
Probably better re-write
Jedoku
force-pushed
the
RHEL-69075-Apply-clang-format-to-vioinput-driver
branch
2 times, most recently
from
3cfce7e to
9576343
Compare
Signed-off-by: Vitalii Chulak <[email protected]>
Signed-off-by: Vitalii Chulak <[email protected]>
Jedoku
force-pushed
the
RHEL-69075-Apply-clang-format-to-vioinput-driver
branch
from
9576343 to
6e99148
Compare
Jedoku
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.