-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small UI fixes #181
Small UI fixes #181
Conversation
Please add me back as a review once it's ready to go :) |
…Also fixed a bug with scatterplot not removing when switching between chart configs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks for adding my suggestions!
I noticed that there is no snackbar notification when updating a note twice, maybe the save isn't triggering every time? I saw you marked the feature as experimental. Maybe we can open an issue for this specifically.
I've approved even though you have the testing in the TODO. Feel free to wait to merge this until we do the testing, or unlink the issue and we can just do it on the main branch after this is merged.
Merging this in since I'm out tomorrow and Friday. Want to show the newest interface for the meeting on Monday. Re snackbar: We can test this more extensively when testing the RE/WR access. I only briefly tested it and it was working so I just proceeded. |
Make scrollable list more apparentI don't know how.padding for heat map row green/blue rectanglesI don't like the white space. Doesn't look very good.