Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small UI fixes #181

Merged
merged 9 commits into from
Sep 22, 2021
Merged

Small UI fixes #181

merged 9 commits into from
Sep 22, 2021

Conversation

haihan-lin
Copy link
Collaborator

@haihan-lin haihan-lin commented Sep 22, 2021

  • Add tooltips for all icons of top menu.
  • Relocate clear filter to gather all filter under the same drawer.
  • font change button should apply to all chart texts/axis/label
  • crowding issue with procedure list
  • Save annotation automatically when out of focus? (experiment)
  • add an "X" or something similar to make the remove of extra pair plots more apparent.
  • padding for legend. alignment issue?
  • move all buttons to the right side and have the logos on the left side.
  • Add a remove all filter button on top of filter drawer.
  • remove text button elevation in add mode.
  • Make scrollable list more apparent I don't know how.
  • padding for heat map row green/blue rectangles I don't like the white space. Doesn't look very good.
  • Address when testing PR: test the changed role W/R access #174

@haihan-lin haihan-lin linked an issue Sep 22, 2021 that may be closed by this pull request
@haihan-lin haihan-lin requested a review from JackWilb September 22, 2021 17:09
@JackWilb JackWilb removed their request for review September 22, 2021 21:11
@JackWilb
Copy link
Member

Please add me back as a review once it's ready to go :)

@haihan-lin haihan-lin marked this pull request as ready for review September 22, 2021 22:02
@haihan-lin haihan-lin requested a review from JackWilb September 22, 2021 22:02
Copy link
Member

@JackWilb JackWilb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for adding my suggestions!

I noticed that there is no snackbar notification when updating a note twice, maybe the save isn't triggering every time? I saw you marked the feature as experimental. Maybe we can open an issue for this specifically.

I've approved even though you have the testing in the TODO. Feel free to wait to merge this until we do the testing, or unlink the issue and we can just do it on the main branch after this is merged.

@haihan-lin
Copy link
Collaborator Author

Merging this in since I'm out tomorrow and Friday. Want to show the newest interface for the meeting on Monday.

Re snackbar: We can test this more extensively when testing the RE/WR access. I only briefly tested it and it was working so I just proceeded.

@haihan-lin haihan-lin merged commit f55e976 into main Sep 22, 2021
@haihan-lin haihan-lin deleted the small-fixes branch September 22, 2021 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants