forked from visdesignlab/aardvark
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added composite tabular data file creation #107
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for dev environment.
Co-authored-by: bbollen23 <[email protected]>
…etSelectionUntrrackedStore into configStore. Moved getSegmentationFileUrl into segmentation store
…ust use 'client/data'
bbollen23
added
bug
Something isn't working
documentation
Improvements or additions to documentation
enhancement
New feature or request
Loon Migration
Features that were in Loon, that must be added to Loonar
backend
Deals with Django backend
labels
Sep 21, 2024
Dev-Lan
requested changes
Oct 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice job! I made some edits directly. There are many commits but all of them are small.
Just a few comments to resolve.
Co-authored-by: Devin Lange <[email protected]>
…s. Fixed uploadStore experiment config watch variable.
…tExperiment progress and removed unwanted info.
Dev-Lan
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
architecture
Deals with general architecture of application
backend
Deals with Django backend
bug
Something isn't working
documentation
Improvements or additions to documentation
enhancement
New feature or request
Loon Migration
Features that were in Loon, that must be added to Loonar
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does this PR close any open issues?
Closes #70 , #72 , #106 , #117 , #119 , #120
Give a longer description of what this PR addresses and why it's needed
TODOs:
EDIT 09/23/24:
To account for adding different scales of "cellMetadata" (i.e. experiment level, location level, etc), we will need to adjust the cellMetaDataStore.
Initial thoughts is that the datastructure should be an object which houses the entirity of the current cellMetaDataStore information so that we can easily access different cellMetaData. For example,
Then, when performing actions against the cell metadata store, we act on one (or more) of these objects. But mostly will be self contained (especially the initializing functions).
I do not think we will need more granularity. The "tagging" element we will eventually have will most likely be stored at the individual location level, so filtering based on this should be simple.
EDIT 09/27/24
After speaking with @Dev-Lan , I was misunderstanding what our goal is. The cell metadata store is mostly meant to just work with the actual cell metadata table. We will only ever load one table at once -- therefore, we do not need to necessarily split this out based on location. We may just have to remove some things from the store that are more general.
Also, we decided to add the "tagging" feature in this branch since it still pertains to the creation of the composite tabular data file.