Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vochain: correctly SetChainID during newTendermint #1151

Merged
merged 3 commits into from
Oct 17, 2023
Merged

vochain: correctly SetChainID during newTendermint #1151

merged 3 commits into from
Oct 17, 2023

Conversation

altergui
Copy link
Contributor

@altergui altergui commented Oct 17, 2023 •
edited
Loading

  • vochain: correctly SetChainID during newTendermint
  • clarify some comments and simplify vocone SetChainID
  • bump dev genesis to vocdoni-dev-25

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6547692533

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 11 unchanged lines in 5 files lost coverage.
  • Overall coverage decreased (-0.009%) to 62.371%
Files with Coverage Reduction New Missed Lines %
api/accounts.go 2 48.79%
apiclient/account.go 2 48.45%
vochain/transaction/admin_tx.go 2 50.0%
vochain/transaction/transaction.go 2 65.59%
cmd/end2endtest/account.go 3 68.57%
Totals Coverage Status
Change from base Build 6536080741: -0.009%
Covered Lines: 14165
Relevant Lines: 22711
💛 - Coveralls

@altergui
Copy link
Contributor Author

fix #1149

@altergui altergui requested a review from p4u October 17, 2023 13:21
@altergui altergui linked an issue Oct 17, 2023 that may be closed by this pull request
bug: state.ChainID() returns empty string #1149
Closed
@altergui altergui changed the title fix/1149 vochain: correctly SetChainID during newTendermint Oct 17, 2023
@altergui altergui merged commit 51f4528 into main Oct 17, 2023
12 checks passed
@altergui altergui deleted the fix/1149 branch October 17, 2023 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p4u p4u p4u approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: state.ChainID() returns empty string
3 participants
@altergui @coveralls @p4u