-
Notifications
You must be signed in to change notification settings - Fork 999
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: if the capability cpu or memory is not specified in the hierarchical queue, it will be set to the corresponding value of the parent queue #3917
base: master
Are you sure you want to change the base?
Conversation
/cc @Monokaix @hwdef @lowang-bh @googs1025 @archlitchi , please have a review thanks |
826142e
to
9754ae3
Compare
3ee8eda
to
08dcdb4
Compare
if len(memory) > 0 { | ||
resourceList[v1.ResourceMemory] = resource.MustParse(memory) | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does scalarResources has same issue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The modification here is just for the convenience of using in UT without passing cpu or memory. You can see that scalarResources is a slice. If it is an empty slice or nil, resourceList will not be assigned.
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
cc @Monokaix |
…ical queue, it will be set to the corresponding value of the parent queue Signed-off-by: JesseStutler <[email protected]>
New changes are detected. LGTM label has been removed. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
fix #3914
validation
Failed to check queue's hierarchical structure
Results:
Hierarchical structure can be successfully checked in capacity plugin, without
Failed to check queue's hierarchical structure
log: