Improve data types #193
Improve data types #193
Conversation
smortex
force-pushed
the
improve-data-types
branch
4 times, most recently
from
1bd0acc to
b9a9dbe
Compare
|
LGTM. But why are the test not run? |
| Optional[String] $pki_keypair = undef, | ||
| Optional[String] $pki_master_key = undef, | ||
| Optional[String] $plugin_dir = undef, | ||
| Array[String[1]] $packages, |
There was a problem hiding this comment.
I think all these spaces in class parameters make things worse. In the worst case, when a paremeter is added or removed, all other parameters need to be aligned again. Sure, these spaces slightly improve readability, but I don't think it's worth it (and it is not covered by puppet-lint).
This PR would be a great opportunity to drop all spaces in class parameters.
There was a problem hiding this comment.
I actually prefer the align variable name and align value style. And the re-indentation on change is not a big issue IMHO. I've seen this discussion before. I think we should have a voxpupuli styleguide (and linter) that finally defines the desired layout. Maybe something to discuss on the ML?
There was a problem hiding this comment.
This was discussed a few times with no consensus as some people can bear it and other people need it to work efficiently, and the status quo is basically "just let people who work with a module do as they like as long as each commit does not switch from one style to another": voxpupuli/voxpupuli.github.io#322
Anyway, be aware that there is an option to not show white-space changes on GitHub (the UI is crappy as hell to find it, the option is on the diff tab, before the actual diff). This makes such annoyances much lower when they happen.
A negative value or 0 are not valid and should not be accepted by the module.
In a future major version, we will remove the support for non-sensitive passwords and stop providing a default value for them.
All user provided String are expected to be non-empty when they are not undef.
smortex
force-pushed
the
improve-data-types
branch
from
b9a9dbe to
1bc1da9
Compare
Some data types allow invalid values. Tighten the data types to make it harder to build broken configuration.