Conversation
Contributor
|
@zezav-cz thank you for this PR. Could you add a test for the new parameter please. |
Contributor
Author
|
@TheMeier Added |
TheMeier
approved these changes
Apr 14, 2026
ananace
requested changes
Apr 17, 2026
| Optional[Integer[0, 65535]] $uid = undef, | ||
| Optional[Integer[0, 65535]] $gid = undef, | ||
|
|
||
| Enum['debug', 'info', 'warn', 'error', 'panic', 'fatal'] $logging_level = 'info', |
Member
There was a problem hiding this comment.
I have a nit regarding the name of the parameter, as it's not a 1:1 map to the ETCD variable like all the other parameters.
It should probably be called log_level instead just to remain consistent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
The ETCD_DEBUG environment variable is deprecated since v3.5, and there is a new option since v3.4 by setting ETCD_LOGGING_LEVEL=debug.
Check: https://etcd.io/docs/v3.4/op-guide/configuration/
This also cause unrecognized variable warning.
This PR removes the unused debug parameter from the etcd cfg template and introduces a new class parameter to specify the etcd log level.
This issue was found by @cowjen01