Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: upgrade vite to v6 #4467

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

feat!: upgrade vite to v6 #4467

wants to merge 1 commit into from

Conversation

sxzz
Copy link
Member

@sxzz sxzz commented Jan 6, 2025

Description

Upgrade Vite to v6

Linked Issues

Additional Context

It's a breaking change in Vite, but it seems no any further changes are needed in VitePress. Please consider bumping the major or minor (at least) version on VP side (Vitest did a major).


Tip

The author of this PR can publish a preview release by commenting /publish below.

@brc-dd
Copy link
Member

brc-dd commented Jan 6, 2025

test.skip('hmr works', async () => {

This test will break. It is skipped but it should work. Need to migrate to new hotUpdate hook for it to work.

@brc-dd
Copy link
Member

brc-dd commented Jan 6, 2025

/publish

Copy link

pkg-pr-new bot commented Jan 6, 2025

npm i https://pkg.pr.new/vitepress@4467

commit: d913a5e

@brc-dd brc-dd added this to the v2.0 milestone Jan 6, 2025
@sxzz sxzz marked this pull request as draft January 7, 2025 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants