Create signet-milestone_1.md

[replghost]

Milestone Delivery Checklist

• The milestone-delivery-template.md has been copied and updated.
• This pull request is being made by the same account as the accepted application.
• I have disclosed any and all sources of reused code in the submitted repositories and have done my due diligence to meet its license requirements.
• In case of acceptance, an invoice must be submitted and the payment will be transferred to the Polkadot/fiat account provided in the application.
• The delivery is according to the Guidelines for Milestone Deliverables.

Link to the application pull request: w3f/Grants-Program#2051

[takahser]

@replghost I've added my initial evaluation here. Feel free to fix the issues related to Testing and Documentation and to ask questions here directly in this thread, should anything be unclear.

[takahser]

@replghost FYI - I'll be out of office for the next 2 weeks. In case you deliver an update to the code and somebody should take a look before I'm back, feel free to ping @keeganquigley or @semuelle on this PR.

[replghost]

Hello @keeganquigley and @semuelle - we have addressed all of the issues that @takahser has brought up so far, and would appreciate if you could take a look. Thanks.

[keeganquigley]

Thanks for your patience @replghost I took over this eval for my colleague while he is out and it looks like the requested unit tests have been written and are successful. However I'm still having trouble running it locally with npm install and npm run dev. Should I be using the siws repo and not the siws-demo repo for testing? Thanks!

npm run dev
npm ERR! Missing script: "dev"
npm ERR!
npm ERR! To see a list of scripts, run:
npm ERR!   npm run

[chrisling-dev]

Thanks for your patience @replghost I took over this eval for my colleague while he is out and it looks like the requested unit tests have been written and are successful. However I'm still having trouble running it locally with npm install and npm run dev. Should I be using the siws repo and not the siws-demo repo for testing? Thanks!

npm run dev
npm ERR! Missing script: "dev"
npm ERR!
npm ERR! To see a list of scripts, run:
npm ERR!   npm run

Hey thanks for the review! You should be using siws-demo repo for testing. Could you double check that you're in the right repo? The package.json does have the dev script for siws-demo https://github.com/TalismanSociety/siws-demo/blob/main/package.json

[keeganquigley]

Thanks for your help @chrisling-dev it's working now in the demo repo. I'm willing to go ahead and pass the milestone, and here you can find the final evaluation. Thanks for your hard work and looking forward to the next one!

[github-actions]

🪙 Please fill out the invoice form in order to initiate the payment process. Thank you!

[github-actions]

Congratulations on completing the first milestone of this grant! As part of the Grants Program, we want to help grant recipients acknowledge their grants publicly. To that end, we've created a badge for projects that successfully deliver their first milestone. Please use the badge only in reference to the work that has been completed as part of this grant, so please do not display it on your team or project's homepage unless accompanied by a short description of the grant. Furthermore, you're now welcome to announce the grant publicly. Please remember to observe the foundation's guidelines in doing so. If you haven't already, reach out to [email protected] for feedback on your announcement and cross-promotion.

Thank you for your contribution, and good luck! If you have any remaining milestone, let us know if you encounter any delays by leaving a comment on the application PR or submitting an amendment.