Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chain Extension Suite #2047
Chain Extension Suite #2047
Changes from 6 commits
a4d6588
4ca3363
f71f137
9e8be48
da10533
b5f9ece
1a8855c
53a20da
a113c01
5597411
876b08a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This deliverable is too vague - it seems like 2-4 already include everything that is specified here. I suggest to either be more specific (if my assumption is wrong) or remove this deliverable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure what you mean here. I've split up the part into four different parts: Architecture, substrate integration, ink integration and code generation. What do you think I'm missing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should think of deliverables as parts of a milestone, that you're going to deliver, rather than the specific steps you have to take to complete a milestone. If I understand correctly, the deliverables 1-4 are all about developing a CLI tool, and deliverable 1 seems to overlap with 2-4, since it basically describes the bootstrap process.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you move this up to the mandatory deliverables? Also, could you include the mandatory docker deliverable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure I can follow. Aren't those all mandatory? Also, this is a CLI tool, there is no use of docker - what should I add here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can find the mandatory deliverables in the application template.
The main reasons we usually require a Docker deliverable is to simplify the testing process and avoid potential dependency & operating system mismatches. If you think that's not applicable in your case, you can just add a comment instead, explaining why you won't add the Docker deliverable.