-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Swush : DEX Aggregator on Polkadot Asset Hub #2440
Conversation
@keeganquigley like we discussed earlier :) |
We plan to store all the assets including all the parachain assets like HDX,GLMR as foreign assets at Polkadot Asset Hub. https://wiki.polkadot.network/docs/build-integrate-assets#foreign-assets
|
I have added some more architecture diagrams in Project Details -> Core Components section and some other clarifications in the proposal. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the application @muddlebee I think the biggest point of contention when discussing this internally with the other committee members was whether this should be funded by a DeFi protocol or DeFi grants program instead of W3F. But seeing that it will be fully integrated with Asset Hub, and have a focus on Plaza, makes me believe that perhaps this could help to jumpstart a solution for what might become an urgent need once smart contracts are live on AH.
One thing I'm not seeing in the application is a comparison to the other mentioned projects. Could you perhaps make a brief comparison to Chain Flip and Squid Router, and how these projects differ? EDIT: I do see that you compare to the other aggregators.
Also, do you foresee any uncertainties related to Plaza's ongoing development? Anything that might need to change along the way?
@keeganquigley thank you for your response.
Hey these are cross chain DEX's which help swap across blockchain networks like MoonBeam <-> Ethereum and other Ethereum L2s outside of Polkadot. I mentioned it as an example to highlight the importance of cross chain solutions.
Currently I dont think so. In our development scope we have added only for Polkadot Asset Hub DEX and Hydration DEX which doesn't involve any smart contracts yet. But down the road we have to figure out on how to integrate smart contracts, which is beyond the scope of development roadmap proposed. |
also some updates on our current Development Status Latest UI : https://swush-labs.github.io/swush-me-app/ UI features enabled
UI demo Recording.2024-11-18.135554.mp4Still in development, we plan to iterate it further :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @muddlebee looks good. I am willing to give it a shot to help jumpstart the initial PoC, but in my opinion after this it would be great if you could hopefully apply for treasury funding or some other source. I will mark as ready for review so the rest of the committee can comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@muddlebee I don't believe you've gone through the KYC/KYB process yet. While waiting for further reviews, could you please complete either KYC verification (for individual check) or KYB verification (for legal entity check, if any). Thanks!
@keeganquigley I have completed my individual KYC. We don't have any legal entity as such. |
@muddlebee just out of curiosity—did you really pay over 28 DOT in fees for a swap on Hydration? That sounds unusually high. Do you know what caused it? I’ve never encountered trading fees anywhere near that level, and to my knowledge, their pools typically yield around ~0.3% APR, so I’m quite surprised. In the meantime, I’ll be reviewing your proposal in detail and will provide additional feedback soon. |
ahh yes, little less than that actually. The screenshot is after I made the swap and realized where the rest of my DOTs went. The reason for high trading fees is due to
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @muddlebee. Sorry for the long wait. I asked our legal team for input, and they asked me to verify that you are not building a DEX yourself, but an aggregator. I can see that this is the case, but just to make sure, is this on your roadmap at all?
Otherwise happy to support!
Hi @semuelle. No worries, and thank you for following up! We are not building a DEX, nor is it on our roadmap. Our primary goal is to serve as a hub for parachain DEXes or a DEX aggregator. |
Hey @muddlebee Different from the similar projects in the ecosystem that you listed I saw Kheopswap which is not focussed on pooling assets themselves or being limited to a single chain. It's also open source and has been retroactively funded via OpenGov. Do you think that it would be possible for you to reuse a lot of it's code? To my understanding there is a lot of overlap in the features between your project and Kheopswap. Maybe this could both reduce your development work and the price of the grant. Otherwise I'm fond of your idea and I would like to see it happening. Please let me know your thoughts here. Best, |
Hey @PieWol thank you for reviewing. Kheopswap is a DEX only for Asset Hubs(Polkadot and Kusama) and my use case is a DEX aggregator to find optimal routes for asset swaps from any of the DEX'es like Asset Hub or Parachain DEX'es like hydration or moonbeam.
for our DEX aggregator we will using the AssetConversion/Assets pallets exposed by the Asset Hub's runtime to get pool liquidity data, asset conversion which I believe must be used by Kheopswap as well. That's the only overlap I could think of. |
I'm exploring an alternative plan to test the end-to-end functionalities using Chopsticks instead of creating live assets on Asset Hub and Hydration or handling cross-chain asset transfers (XCM). Chopsticks by Acala allows forking live networks and running simulations with developer accounts like Alice and Bob. Initially, I was doubtful whether these tools could fully test all functionalities of our DEX Aggregator. However, after exploring the Asset Transfer API by Parity and Chopsticks, I found that they match some of our use cases. That said, this approach could have some limitations which we have not faced or explored yet, and they might affect our proposed milestones. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@muddlebee if you could add this feature, I'd be happy to support this proposal as well.
working on it :) exploring the limitations currently so we don't miss out on milestone goals |
hey @keeganquigley we can use Chopsticks in addition to creating live assets on Asset Hub and Hydration as mentioned here so I'm thinking how to include this in my current milestones. some concerns were raised for creation of live assets on the Polkadot Asset Hub, so is it okay to keep this in addition to chopsticks? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@muddlebee thanks for your replies.
Regarding the Add Liquidity feature I changed my mind: I changed my mind.
Happy to support this as well. 💪
Thanks @muddlebee can you explain how it would change the milestones? I think the use of Chopsticks isn't an issue... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy to proceed.
Congratulations and welcome to the Web3 Foundation Grants Program! Please refer to our Milestone Delivery repository for instructions on how to submit milestones and invoices, our FAQ for frequently asked questions and the support section on our website for more ways to find answers to your questions. |
hey @keeganquigley also I added a simulation testing env in Milestone 1. Here earlier plan was to create mock APIs from scratch and create a simulation test env, but this is also achievable with Chopsticks. So if creating live assets on AH and hydration is not an issue in Milestone 2, we can keep as it is and for the simulation testing env in Milestone 1, I can just use chopsticks? |
Thank you so much, team, for approving the proposal 🚀 and for your patience throughout the process. I’m really excited and ambitious about the DEX Aggregator, which could be further boosted by the full-fledged release of Plaza and the upcoming smart contracts support on Asset Hub. A big thanks to @keeganquigley for helping shape the idea and brainstorming with me to bring this proposal together. |
Project Abstract
Swush is a DEX aggregator built on Polkadot Asset Hub, specifically to meet the needs of Polkadot’s cross-chain DeFi users. By leveraging cross-chain messaging (XCM), and aggregating assets from multiple parachains, Swush allows users to swap assets seamlessly across the ecosystem with minimal friction.
Full proposal can be found here
Grant level
Application Checklist
project_name.md
).@_______:matrix.org
(change the homeserver if you use a different one)