Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Benchmarks #326

Draft
wants to merge 53 commits into
base: master
Choose a base branch
from
Draft

[WIP] Benchmarks #326

wants to merge 53 commits into from

Conversation

djps
Copy link
Collaborator

@djps djps commented Feb 25, 2024

As a work in progress, can't be merged, but

  • What figures and analysis should be performed?

As it is not part of the k-wave example set things are less well-defined.

Copy link

codecov bot commented Feb 25, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 6 lines in your changes missing coverage. Please review.

Project coverage is 72.11%. Comparing base (ca00488) to head (d36f55d).

Files with missing lines Patch % Lines
kwave/utils/filters.py 66.66% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #326      +/-   ##
==========================================
+ Coverage   72.09%   72.11%   +0.02%     
==========================================
  Files          46       46              
  Lines        6747     6752       +5     
  Branches     1496     1496              
==========================================
+ Hits         4864     4869       +5     
  Misses       1326     1326              
  Partials      557      557              
Flag Coverage Δ
3.10 72.31% <66.66%> (+0.02%) ⬆️
3.11 72.31% <66.66%> (+0.02%) ⬆️
3.12 72.31% <66.66%> (+0.02%) ⬆️
3.9 72.08% <66.66%> (+0.02%) ⬆️
macos-latest 72.05% <66.66%> (+0.02%) ⬆️
ubuntu-latest 72.08% <66.66%> (+0.02%) ⬆️
windows-latest 72.09% <66.66%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@waltsims
Copy link
Owner

Since it is a benchmark a description of the benchmark with a link to the paper, one figure and a table with the performance results would be a good place to start. What do you think?

@waltsims waltsims marked this pull request as draft February 27, 2024 01:51
@waltsims
Copy link
Owner

Hi @djps could any of these examples be merged in on their own?

@djps
Copy link
Collaborator Author

djps commented Sep 23, 2024

Hi @djps could any of these examples be merged in on their own?

Yes, but I thought you had said that it would be preferable to have a method which defines the medium, geometry etc and then pass the example number as an argument to the code which then constructs the benchmark.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants