-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Benchmarks #326
base: master
Are you sure you want to change the base?
[WIP] Benchmarks #326
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #326 +/- ##
==========================================
+ Coverage 72.09% 72.11% +0.02%
==========================================
Files 46 46
Lines 6747 6752 +5
Branches 1496 1496
==========================================
+ Hits 4864 4869 +5
Misses 1326 1326
Partials 557 557
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Since it is a benchmark a description of the benchmark with a link to the paper, one figure and a table with the performance results would be a good place to start. What do you think? |
Hi @djps could any of these examples be merged in on their own? |
Yes, but I thought you had said that it would be preferable to have a method which defines the medium, geometry etc and then pass the example number as an argument to the code which then constructs the benchmark. |
As a work in progress, can't be merged, but
As it is not part of the k-wave example set things are less well-defined.