feat: favicon.ico

warmachine028 · Nov 13, 2024 · 0102015 · 0102015 · vercel · Nov 13, 2024
1 parent 03dbf55
commit 0102015
Show file tree

Hide file tree

Showing 8 changed files with 8 additions and 22 deletions.
diff --git a/client/bun.lockb b/client/bun.lockb
diff --git a/client/src/app/favicon.ico b/client/src/app/favicon.ico
diff --git a/client/src/app/favicon.svg b/client/src/app/favicon.svg
diff --git a/client/src/app/layout.tsx b/client/src/app/layout.tsx
@@ -31,9 +31,6 @@ const RootLayout = ({ children }: Readonly<{ children: React.ReactNode }>) => {
 	return (
 		//? FIX: https://github.com/shadcn-ui/ui/issues/1906#issuecomment-1807426212
 		<html lang="en" suppressHydrationWarning>
-			<head>
-				<link rel="icon" href="/favicon.svg" sizes='any' />
-			</head>
 			<body className={`${geistSans.variable} ${geistMono.variable}`}>
 				<NextSSRPlugin routerConfig={extractRouterConfig(fileRouter)} />
 				<ReactQueryprovider>

diff --git a/client/src/app/manifest.ts b/client/src/app/manifest.ts
@@ -11,9 +11,9 @@ export default function manifest(): MetadataRoute.Manifest {
 		theme_color: '#000000',
 		icons: [
 			{
-				src: '/favicon.svg',
+				src: '/favicon.ico',
 				sizes: '192x192',
-				type: 'image/svg'
+				type: 'image/ico'
 			}
 		]
 	}

diff --git a/client/src/app/vercel/favicon.ico b/client/src/app/vercel/favicon.ico
diff --git a/client/src/components/Menubar.tsx b/client/src/components/Menubar.tsx
@@ -12,7 +12,6 @@ interface MenubarProps {
 
 const Menubar = ({ className }: MenubarProps) => {
 	const pathname = usePathname()
-	const notificationCount = 100
 	return (
 		<aside className={cn('text-primary', className)}>
 			<Button
@@ -30,15 +29,17 @@ const Menubar = ({ className }: MenubarProps) => {
 				</Link>
 			</Button>
 			<Button
-				className="relative flex items-center justify-start gap-3 ring-primary"
+				className="flex items-center justify-start gap-3 ring-primary"
 				variant="ghost"
 				title="Notifications"
 				asChild
 			>
 				<Link href="/notifications">
-					<BellRing />
+					<div className="relative">
+						<BellRing />
+						<div className="absolute -right-1 -top-1 flex h-2.5 w-2.5 items-center justify-center rounded-full bg-destructive text-xs" />
+					</div>
 					<span className="hidden lg:inline">Notifications</span>
-					<div className="absolute right-2.5 top-1 flex h-2.5 w-2.5 items-center justify-center rounded-full bg-destructive text-xs" />
 				</Link>
 			</Button>
 			<Button

diff --git a/client/src/components/TrendsSidebar.tsx b/client/src/components/TrendsSidebar.tsx
@@ -28,9 +28,7 @@ const getTrendingTopics = unstable_cache(
 		}))
 	},
 	['trending_topics'],
-	{
-		revalidate: 3 * 60 * 60 // 3 hrs
-	}
+	{ revalidate: 60 * 60 * 3 } // 3 hrs
 )
 
 const TrendingTopics = async () => {