Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT] standardize wadm API response enums #534

Open
brooksmtownsend opened this issue Jan 2, 2025 · 0 comments · May be fixed by #538
Open

[FEAT] standardize wadm API response enums #534

brooksmtownsend opened this issue Jan 2, 2025 · 0 comments · May be fixed by #538
Labels
good first issue Good for newcomers rust Pull requests that update Rust code

Comments

@brooksmtownsend
Copy link
Member

Currently, there are multiple different "result" enums like the GetResult that have Error, Success and NotFound; PutResult that have Error, Created and NewVersion; DeleteResult that has Deleted, Error and Noop, etc etc.

I propose we standardize at the very least the Error and Success responses, and have additional operation-specific results. This would mean changing PutResult to have Error and Success (with a message for the new version), DeleteResult to be Error, Success (with a message for noop) etc.
@brooksmtownsend brooksmtownsend added good first issue Good for newcomers rust Pull requests that update Rust code labels Jan 2, 2025
@markkovari markkovari linked a pull request Jan 5, 2025 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers rust Pull requests that update Rust code
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ref(wadm-types): simplify results WIP markkovari/wadm
1 participant
@brooksmtownsend