ref(wadm-types): simplify results WIP #538
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Problem
resolves: #534
By
if I understand correctly we want to reduce the tagged unions top level fields only, right?
Not sure which is better here, if the Success value has an
Option<String>
only or if there is an other enum, which has two different values.And another question: should this change modify
PutModelResponse
smessage
field in any way?a. version a (here the optional "message" is not really descriptive, but pretty much the same the other version)
b. version b
not sure which is more clear. 🤔
Before going and implementing it all the way through I would rather ask a for a quick feedback.
Thanks
p.s.: please ignore the other changes for now, just wanted to make things faster
Related Issues
Release Information
Consumer Impact
Testing
Unit Test(s)
Acceptance or Integration
Manual Verification