Ignore presentation time if visibility changed, for Event Timing #37039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Nov 19, 2022
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3926369
branch
5 times, most recently
from
ab58b4b to
cfd7f0a
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3926369
branch
from
cfd7f0a to
bb01009
Compare
EventTiming registers for presentation feedback times for events which are expected to have a visual update. However, if page visibility changes, that can affect the time it takes to present the next paint update. We were already ignoring the time to next paint portion for UKM reporting of interactions, but now we also ignore this time for Event Timing reporting to Web Performance timeline. Filed a spec issue with EventTiming API to clarify cases where events will not have a next paint: w3c/event-timing#123 Also, we will follow-up to see if it is not desirable to measure all the way until visibility change, as per: w3c/event-timing#129 Bug: 1312568 Change-Id: Iee0b5eee81fb216a96ecbfcc41ca26601ab6ba1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3926369 Commit-Queue: Michal Mocny <[email protected]> Auto-Submit: Michal Mocny <[email protected]> Reviewed-by: Noam Rosenthal <[email protected]> Cr-Commit-Position: refs/heads/main@{#1093452}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3926369
branch
from
bb01009 to
ac2138e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EventTiming registers for presentation feedback times for events which
are expected to have a visual update. However, if page visibility
changes, that can affect the time it takes to present the next paint
update.
We were already ignoring the time to next paint portion for UKM
reporting of interactions, but now we also ignore this time for Event
Timing reporting to Web Performance timeline.
Filed a spec issue with EventTiming API to clarify cases where events
will not have a next paint:
w3c/event-timing#123
Also, we will follow-up to see if it is not desirable to measure all the
way until visibility change, as per:
w3c/event-timing#129
Bug: 1312568
Change-Id: Iee0b5eee81fb216a96ecbfcc41ca26601ab6ba1b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3926369
Commit-Queue: Michal Mocny <[email protected]>
Auto-Submit: Michal Mocny <[email protected]>
Reviewed-by: Noam Rosenthal <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1093452}