Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update html-aam/roles-contextual.html with <summary> tests #43859

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Update html-aam/roles-contextual.html with <summary> tests #43859

Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5fe503e
Add html-aam <summary> contextual tests
Jan 4, 2024
4f207dc
Remove unneeded ARIA
Jan 4, 2024
0044ea7
Fix 'not first <summary>' test
Jan 5, 2024
4e0b589
Create ./summary.html, update documentation reference links in ./role…
Apr 7, 2024
333c3df
Remove unused verifyRoles..() in script block
Apr 7, 2024
4f22d66
Add test for intervening element after <details>
rahimabdi Apr 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions html-aam/roles-contextual.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,16 @@
<section data-testname="el-section" aria-label="x" data-expectedrole="region" class="ex">x</section>
<section data-testname="el-section-no-name" class="ex-generic">x</section>

<!-- el-summary -->
<summary data-testname="el-summary-orphan" class="ex-generic">x</summary>
<details>
<ol>
<li>x</li>
<li>x</li>
</ol>
<summary>x</summary>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not test this, the only semantic summary example?

<summary data-testname="el-summary-not-first-summary-child-of-details" class="ex-generic">x</summary>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any idea why this one fails in WebKit with the following?

FAIL message: promise_test: Unhandled rejection with value: "error: Action get_computed_role failed"

Copy link
Contributor Author

@rahimabdi rahimabdi Apr 7, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's due to an unused AriaUtils.verifyRolesBySelector(".ex") in the <script> block since we're only testing generic stuff. I've removed it in 333c3df, re-running CI tests now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like there's not an issue in Gecko/Chromium (perhaps WebKit is not exposing the <summary> in this context as an accessible object)?

</details>

<script>
AriaUtils.verifyRolesBySelector(".ex");
Expand Down