Add support for Python 3.13 #49970
Open
Add support for Python 3.13 #49970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This code has been dropped from Python 3.13, but we depend on FieldStorage as part of the request API. The easiest option here is to directly import the code that we are already using (the last version on the 3.12 branch, but with the deprecation warning removed), along with a copy of the PSF License which covers the cgi module code.
…ck API This is required since the logging module started using the lock as a context manager, and calling the acquire and release methods.
Remove code only needed for Python < 3.4 and ensure that we always use the spawn form of multiprocessing to avoid problems with fork and locks.
wpt-pr-bot
added
Azure Pipelines
ci
infra
manifest
serve
tox.ini
wave
wpt
wptrunner
gsnedders
reviewed
Jan 8, 2025
Comment on lines
+7
to
+8
| pillow==10.4.0; python_version < '3.13' | ||
| pillow==11.1.0; python_version >= '3.13' |
There was a problem hiding this comment.
Do we want to just make this python_version < '3.9', which means 3.8 (which I think we're closing to dropping support for?) is the only outlier?
| @@ -77,7 +77,7 @@ def __init__(self, queue, level=logging.NOTSET): | |||
|
|
|||
| def createLock(self): | |||
| # The queue provides its own locking | |||
| self.lock = None | |||
| self.lock = NullLock() | |||
There was a problem hiding this comment.
What motivates this change? This doesn't look like it should be related to Python 3.13 changes?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notably this involves vendoring a copy of the removed cgi module from stdlib.