This repository has been archived by the owner on Sep 20, 2019. It is now read-only.
#551 - V1 custom elements - missing functionality #552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…edCallback() for all existing attributes.
…r variable function declarations
treshugart
changed the title
treshugart
changed the title
| @@ -237,11 +243,21 @@ var CustomElementDefinition; | |||
| new (definition.constructor)(); | |||
| console.assert(this._newInstance == null); | |||
| } | |||
| if (definition.attributeChangedCallback && definition.observedAttributes.length > 0) { | |||
|
|
|||
| var observedAttributes = definition.observedAttributes; | |||
There was a problem hiding this comment.
Changed this to lookup the property only once since there's multiple lookups below.
| var xboo = new XBoo(); | ||
| xboo.setAttribute('test1', 'test1'); | ||
| xboo.setAttribute('test2', 'test2'); | ||
| customElements.flush(); |
There was a problem hiding this comment.
This seemed to be how other tests were initiating an upgrade pass. I'll get the tests running and then correct this if need be.
|
Closing so I can separate the features added. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #551.
I had some issues running the v1 tests which I'm going to try and get running now.