Remove default values from public properties always assigned in the constructor

CHANGELOG.md

@@ -9,6 +9,10 @@ You can find and compare releases at the [GitHub release page](https://github.co
 
 ## Unreleased
 
+### Changed
+
+- Remove default values from public properties that are always assigned in the constructor https://github.com/webonyx/graphql-php/pull/1959
+
 ## v15.37.2
 
 ### Changed

rector.php

@@ -17,7 +17,6 @@
         Rector\DeadCode\Rector\ClassMethod\RemoveParentDelegatingConstructorRector::class => [
             __DIR__ . '/src/Type/Definition/CustomScalarType.php', // Refines PHPDoc types
         ],
-        Rector\DeadCode\Rector\Property\RemoveDefaultValueFromAssignedPropertyRector::class, // TODO reintroduce in v16 https://github.com/webonyx/graphql-php/pull/1959 - dropping defaults from public properties breaks reading them when the constructor is bypassed
         Rector\DeadCode\Rector\Property\RemoveUnusedPrivatePropertyRector::class, // TODO reintroduce when https://github.com/rectorphp/rector-src/pull/4491 is released
         Rector\DeadCode\Rector\StmtsAwareInterface\RemoveDeadInstanceOfAssertRector::class, // Sometimes necessary to prove runtime behavior matches defined types
         Rector\PHPUnit\CodeQuality\Rector\Class_\NarrowUnusedSetUpDefinedPropertyRector::class, // Sometimes nicer for symmetry

src/Executor/ExecutionResult.php

@@ -40,7 +40,7 @@ class ExecutionResult implements \JsonSerializable
      *
      * @var array<string, mixed>|null
      */
-    public ?array $data = null;
+    public ?array $data;
 
     /**
      * Errors registered during query execution.
@@ -52,7 +52,7 @@ class ExecutionResult implements \JsonSerializable
      *
      * @var list<Error>
      */
-    public array $errors = [];
+    public array $errors;
 
     /**
      * User-defined serializable array of extensions included in serialized result.
@@ -61,7 +61,7 @@ class ExecutionResult implements \JsonSerializable
      *
      * @var array<string, mixed>|null
      */
-    public ?array $extensions = null;
+    public ?array $extensions;
 
     /**
      * @var callable|null

src/Language/AST/Location.php

@@ -20,13 +20,13 @@ class Location
     public int $end;
 
     /** The Token at which this Node begins. */
-    public ?Token $startToken = null;
+    public ?Token $startToken;
 
     /** The Token at which this Node ends. */
-    public ?Token $endToken = null;
+    public ?Token $endToken;
 
     /** The Source document the AST represents. */
-    public ?Source $source = null;
+    public ?Source $source;
 
     public static function create(int $start, int $end): self
     {

src/Type/Definition/ResolveInfo.php

@@ -98,7 +98,7 @@ class ResolveInfo
      *
      * @var array<string, FragmentDefinitionNode>
      */
-    public array $fragments = [];
+    public array $fragments;
 
     /**
      * Root value passed to query execution.
@@ -123,7 +123,7 @@ class ResolveInfo
      *
      * @var array<string, mixed>
      */
-    public array $variableValues = [];
+    public array $variableValues;
 
     /**
      * @param \ArrayObject<int, FieldNode> $fieldNodes

src/Type/Schema.php

@@ -78,7 +78,7 @@ class Schema
     public ?SchemaDefinitionNode $astNode;
 
     /** @var array<SchemaExtensionNode> */
-    public array $extensionASTNodes = [];
+    public array $extensionASTNodes;
 
     /**
      * @param SchemaConfig|array<string, mixed> $config