chore: Rename the package to webship/patches and drop the cleanup commands - #4
Merged
Merged
Conversation
…mands Rename the Composer package from webship/webship-patches to webship/patches, move the PHP namespace to Webship\Patches and rename the plugin and capability classes to PatchesPlugin and ResolverProvider. Depend on webship/drupal-patches and serve every patch file from the patches branch of webship/patches. Remove the two Composer cleanup commands and everything that only existed for them: the CommandProvider capability, CleanupPatchesCommand, CleanupPatchesFileCommand, Util\MrPatchProcessor, docs/commands.md and docs/migration-from-drush.md. Narrow cweagans/composer-patches to ~2.0 and remove the v1 compatibility path, which duplicated the FilteredDependencies resolver in a second implementation kept in step by hand. Sweep the last Vardot and Varbase naming out of the repository. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem/Motivation
The package name repeats the vendor (
webship/webship-patches), the PHP namespace and classes repeat it again (Webship\WebshipPatches\WebshipPatchesPlugin), and the repository still carried Vardot/Varbase naming in places the earlier sweep missed.Separately, the package shipped two Composer cleanup commands and a v1 compatibility path for
cweagans/composer-patches, neither of which Webship uses.Proposed resolution
Rename
webship/webship-patches→webship/patches(the GitHub repository is already renamed; the old URL redirects).Webship\WebshipPatches\→Webship\Patches\.WebshipPatchesPlugin→PatchesPlugin,WebshipResolverProvider→ResolverProvider.webship/drupal-core-patches→webship/drupal-patches.patchesbranch ofwebship/patches.Remove the Composer cleanup commands
patches:cleanup:patches/:patches-file(web-ccup/web-ccupf) are gone, along with everything that existed only to serve them: theCommandProvidercapability,CleanupPatchesCommand,CleanupPatchesFileCommand,Util\MrPatchProcessor,docs/commands.mdanddocs/migration-from-drush.md.src/is now just the plugin, the resolver capability andFilteredDependencies.cweagans/composer-patches ~2.0 only
The constraint narrows from
"~1.7.0 || ~2.0"to"~2.0", and the v1 path is removed — it was a second implementation of the merge/allowlist/patches-ignorerules, duplicatingFilteredDependenciesand kept in step by hand. The~1.7.0leg of the CI matrix goes with it.Housekeeping
Every remaining
Vardot/Varbasereference is gone..patchand.difffiles were left untouched — they are immutable diffs whose checksums matter.How it was tested
webship/patcheslocation.php -lclean on every file undersrc/andtests/;composer.json,tests/test.composer.jsonand the workflow YAML all parse.vardot,varbase,webship-patches,drupal-core-patches,WebshipPatches,ccup,CommandProvider,MrPatchProcessorand~1.7returns nothing.Follow-up, not in this PR
webship/patchesto Packagist. Per your call the oldwebship/webship-patchesentry is left as-is rather than marked abandoned.webship/ai-agentsstill reference the old package names — left alone deliberately, as agreed.Checkpoints
🤖 Generated with Claude Code