Skip to content

chore: Rename the package to webship/patches and drop the cleanup commands - #4

Merged
Natshah merged 1 commit into
11.0.xfrom
chore/rename-to-webship-patches
Jul 25, 2026
Merged

Natshah merged 1 commit into
11.0.xfrom
chore/rename-to-webship-patches

Conversation

@Natshah

@Natshah Natshah commented Jul 25, 2026

Copy link
Copy Markdown
Member

Problem/Motivation

The package name repeats the vendor (webship/webship-patches), the PHP namespace and classes repeat it again (Webship\WebshipPatches\WebshipPatchesPlugin), and the repository still carried Vardot/Varbase naming in places the earlier sweep missed.

Separately, the package shipped two Composer cleanup commands and a v1 compatibility path for cweagans/composer-patches, neither of which Webship uses.

Proposed resolution

Rename

  • Composer package webship/webship-patcheswebship/patches (the GitHub repository is already renamed; the old URL redirects).
  • PHP namespace Webship\WebshipPatches\Webship\Patches\.
  • WebshipPatchesPluginPatchesPlugin, WebshipResolverProviderResolverProvider.
  • Dependency webship/drupal-core-patcheswebship/drupal-patches.
  • Every patch file URL now points at the patches branch of webship/patches.

Remove the Composer cleanup commands

patches:cleanup:patches / :patches-file (web-ccup / web-ccupf) are gone, along with everything that existed only to serve them: the CommandProvider capability, CleanupPatchesCommand, CleanupPatchesFileCommand, Util\MrPatchProcessor, docs/commands.md and docs/migration-from-drush.md. src/ is now just the plugin, the resolver capability and FilteredDependencies.

cweagans/composer-patches ~2.0 only

The constraint narrows from "~1.7.0 || ~2.0" to "~2.0", and the v1 path is removed — it was a second implementation of the merge/allowlist/patches-ignore rules, duplicating FilteredDependencies and kept in step by hand. The ~1.7.0 leg of the CI matrix goes with it.

This part was previously #3, which was closed without merging. It is folded in here because you had asked for v2-only; if closing it was deliberate, say so and I will split it back out.

Housekeeping

Every remaining Vardot / Varbase reference is gone. .patch and .diff files were left untouched — they are immutable diffs whose checksums matter.

How it was tested

  • All 34 rewritten patch URLs fetched and returned HTTP 200 at the new webship/patches location.
  • php -l clean on every file under src/ and tests/; composer.json, tests/test.composer.json and the workflow YAML all parse.
  • Full-text sweep for vardot, varbase, webship-patches, drupal-core-patches, WebshipPatches, ccup, CommandProvider, MrPatchProcessor and ~1.7 returns nothing.

Follow-up, not in this PR

  • Submit webship/patches to Packagist. Per your call the old webship/webship-patches entry is left as-is rather than marked abandoned.
  • The agents and skills in webship/ai-agents still reference the old package names — left alone deliberately, as agreed.

Checkpoints

  • File an issue about this project
  • Addition/Change/Update/Fix to this project
  • Testing to ensure no regression
  • Automated unit/functional testing coverage
  • Developer Documentation support on feature change/addition
  • User Guide Documentation support on feature change/addition
  • Accessibility and Readability
  • Code review by maintainers
  • Full testing and approval
  • Credit contributors
  • Review with the product owner
  • Update Release Notes
  • Release

🤖 Generated with Claude Code

…mands

Rename the Composer package from webship/webship-patches to
webship/patches, move the PHP namespace to Webship\Patches and rename the
plugin and capability classes to PatchesPlugin and ResolverProvider.
Depend on webship/drupal-patches and serve every patch file from the
patches branch of webship/patches.

Remove the two Composer cleanup commands and everything that only existed
for them: the CommandProvider capability, CleanupPatchesCommand,
CleanupPatchesFileCommand, Util\MrPatchProcessor, docs/commands.md and
docs/migration-from-drush.md.

Narrow cweagans/composer-patches to ~2.0 and remove the v1 compatibility
path, which duplicated the FilteredDependencies resolver in a second
implementation kept in step by hand.

Sweep the last Vardot and Varbase naming out of the repository.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@Natshah
Natshah merged commit d45bfae into 11.0.x Jul 25, 2026
1 of 2 checks passed
@Natshah
Natshah deleted the chore/rename-to-webship-patches branch July 25, 2026 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant