Remove a patch for the Chaos Tool Suite (ctools) module on fix: #3492432 PHP 8.4 nullable types in MaskContentEntityStorage::doLoadMultiple() -- after ctools 4.1.1 was released - #7
Closed
Natshah wants to merge 1 commit into
Conversation
…432 PHP 8.4 nullable types in MaskContentEntityStorage::doLoadMultiple() -- after ctools 4.1.1 was released ctools 4.1.1 already ships the nullable-parameter fix (doLoadMultiple(?array $ids = NULL)), so the patch can no longer apply and breaks composer install on the 11.0.x line. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes the ctools patch declaration for #3492432 — PHP 8.4 nullable types in
MaskContentEntityStorage::doLoadMultiple()— from the11.0.xpatch list.Why
ctools 4.1.1 already ships this fix upstream (
doLoadMultiple(?array $ids = NULL)is in the 4.1.1 tag), so the patch can never apply. It fails theTest patchesworkflow on11.0.xHEAD with:(runs 30178289385 on
8e5b4ea, failed twice including a re-run after thepatchesstore branch was updated).The other ctools patch (#3572317) is kept. The obsolete
.patchfile is left on thepatchesstore branch (file store only, harmless).This unblocks cutting the first
11.0.0tag ofwebship/patches— the branch is release-ready once this lands green.🤖 Generated with Claude Code